Skip to content

Update sync script#472

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tmshort:fix-sync-sh
Mar 24, 2023
Merged

Update sync script#472
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tmshort:fix-sync-sh

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented Mar 14, 2023

Update the remote repo names
The flag arguments to sync_pop_candidate need to be first

@tmshort
Update sync script
7a02938 
Update the remote repo names
The flag arguments to sync_pop_candidate need to be first

Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci openshift-ci Bot requested review from anik120 and dinhxuanvu March 14, 2023 19:08
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 14, 2023

@perdasilva Can you take a look given #465?

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 15, 2023

/retest

1 similar comment
@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 15, 2023

/retest

ankitathomas
ankitathomas approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 15, 2023

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 15, 2023

/retest

5 similar comments
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 16, 2023

/retest

@ankitathomas
Copy link
Copy Markdown
Contributor

ankitathomas commented Mar 18, 2023

/retest

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 20, 2023

/retest

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 20, 2023

/retest

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 20, 2023

/retest

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 22, 2023

/override ci/prow/e2e-upgrade

overriding as changes don't affect product

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 22, 2023

/label docs-approved

@openshift-ci openshift-ci Bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 22, 2023
@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 22, 2023

/label px-approved

@openshift-ci openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Mar 22, 2023
@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 22, 2023

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Mar 22, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 22, 2023

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-upgrade

overriding as changes don't affect product

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 22, 2023

/retest-required

Remaining retests: 0 against base HEAD 88f2e1e and 2 for PR HEAD 7a02938 in total

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Mar 22, 2023

Looks like I need a (bugzilla/valid-bug) label?

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 22, 2023

/retest-required

Remaining retests: 0 against base HEAD 3a82ea6 and 1 for PR HEAD 7a02938 in total

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 24, 2023

/override ci/prow/e2e-upgrade

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 24, 2023

overriding as this PR has not affect on product

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 24, 2023

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 24, 2023

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 440894b into openshift:master Mar 24, 2023
@tmshort tmshort deleted the fix-sync-sh branch April 6, 2023 13:54
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Feb 6, 2026
@dependabot @tmshort
Bump github.com/google/cel-go from 0.26.1 to 0.27.0 (openshift#472)
253e01b 
Bumps [github.com/google/cel-go](https://github.com/google/cel-go) from 0.26.1 to 0.27.0.
- [Release notes](https://github.com/google/cel-go/releases)
- [Commits](google/cel-go@v0.26.1...v0.27.0)

---
updated-dependencies:
- dependency-name: github.com/google/cel-go
  dependency-version: 0.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: c8bc31e65aac04530700bce23570f75c0d690d85
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Feb 6, 2026
@dependabot @tmshort
Bump github.com/google/cel-go from 0.26.1 to 0.27.0 (openshift#472)
554de2a 
Bumps [github.com/google/cel-go](https://github.com/google/cel-go) from 0.26.1 to 0.27.0.
- [Release notes](https://github.com/google/cel-go/releases)
- [Commits](google/cel-go@v0.26.1...v0.27.0)

---
updated-dependencies:
- dependency-name: github.com/google/cel-go
  dependency-version: 0.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: c8bc31e65aac04530700bce23570f75c0d690d85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

1 more reviewer

@ankitathomas ankitathomas ankitathomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ankitathomas ankitathomas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmshort @perdasilva @ankitathomas @openshift-ci-robot @openshift-merge-robot