OCPBUGS-17791: opm: always serve pprof endpoints, improve server allocations (#1129)

[stevekuznetsov]

• pkg/cache: use a shared buffer to limit allocations

Previously, new buffers were allocated on each file we read in, which was unnecessary and wasteful.

• cmd/opm: serve pprof endpoints by default

There is no substantial runtime cost to serving pprof endpoints, and when things hit the fan and we need to investigate performance in situ, there is no time to restart pods and change flags. Capturing profiles remains opt-in, since those are costly.

---

Upstream-repository: operator-registry
Upstream-commit: 68e13df96590977370ffcd1a8e9ff76e0f2a03f2

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17695, which is invalid:

• expected Jira Issue OCPBUGS-17695 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

• pkg/cache: use a shared buffer to limit allocations

Previously, new buffers were allocated on each file we read in, which was unnecessary and wasteful.

• cmd/opm: serve pprof endpoints by default

There is no substantial runtime cost to serving pprof endpoints, and when things hit the fan and we need to investigate performance in situ, there is no time to restart pods and change flags. Capturing profiles remains opt-in, since those are costly.

---

Upstream-repository: operator-registry
Upstream-commit: 68e13df96590977370ffcd1a8e9ff76e0f2a03f2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bparees]

can you link to the 4.14 version of this PR so we can confirm it went into 4.14 before backporting to 4.13?

[stevekuznetsov]

@bparees sure thing! The other PR was #526

[stevekuznetsov]

/retest

[joelanford]

/label backport-risk-assessed

[stevekuznetsov]

/retest

[openshift-ci-robot]

@stevekuznetsov: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

• pkg/cache: use a shared buffer to limit allocations

Previously, new buffers were allocated on each file we read in, which was unnecessary and wasteful.

• cmd/opm: serve pprof endpoints by default

There is no substantial runtime cost to serving pprof endpoints, and when things hit the fan and we need to investigate performance in situ, there is no time to restart pods and change flags. Capturing profiles remains opt-in, since those are costly.

---

Upstream-repository: operator-registry
Upstream-commit: 68e13df96590977370ffcd1a8e9ff76e0f2a03f2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

/jira cherry-pick OCPBUGS-17758

[stevekuznetsov]

/jira cherrypick OCPBUGS-17758

[openshift-ci-robot]

@stevekuznetsov: Jira Issue OCPBUGS-17758 has been cloned as Jira Issue OCPBUGS-17791. Will retitle bug to link to clone.
/retitle OCPBUGS-17791: opm: always serve pprof endpoints, improve server allocations (#1129)

Details

In response to this:

/jira cherrypick OCPBUGS-17758

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17791, which is invalid:

• expected dependent Jira Issue OCPBUGS-17758 to target a version in 4.14.0, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

• pkg/cache: use a shared buffer to limit allocations

Previously, new buffers were allocated on each file we read in, which was unnecessary and wasteful.

• cmd/opm: serve pprof endpoints by default

There is no substantial runtime cost to serving pprof endpoints, and when things hit the fan and we need to investigate performance in situ, there is no time to restart pods and change flags. Capturing profiles remains opt-in, since those are costly.

---

Upstream-repository: operator-registry
Upstream-commit: 68e13df96590977370ffcd1a8e9ff76e0f2a03f2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

/jira refresh

[openshift-ci-robot]

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17791, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-17758 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-17758 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

/retest

[grokspawn]

/lgtm

[stevekuznetsov]

/retest

[stevekuznetsov]

/retest

[gallettilance]

/approve

[joelanford]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gallettilance, joelanford, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KeenonLee]

/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 142d758 and 2 for PR HEAD 4c80bff in total

[KeenonLee]

/retest

[stevekuznetsov]

/retest

[stevekuznetsov]

/retest

[openshift-ci]

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@stevekuznetsov: Jira Issue OCPBUGS-17791 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

• pkg/cache: use a shared buffer to limit allocations

Previously, new buffers were allocated on each file we read in, which was unnecessary and wasteful.

• cmd/opm: serve pprof endpoints by default

There is no substantial runtime cost to serving pprof endpoints, and when things hit the fan and we need to investigate performance in situ, there is no time to restart pods and change flags. Capturing profiles remains opt-in, since those are costly.

---

Upstream-repository: operator-registry
Upstream-commit: 68e13df96590977370ffcd1a8e9ff76e0f2a03f2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.