OPRUN-1873: scripts/bumper: automate pushing changes and creating PRs#550
Conversation
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
| var missingCommits []commit | ||
| for _, commit := range commits { | ||
| commitLogger := logger.WithField("commit", commit.Hash) | ||
| missing, err := isCommitMissing(ctx, commitLogger, opts.stagingDir, commit) | ||
| if err != nil { | ||
| commitLogger.WithError(err).Fatal("failed to determine if commit is missing") | ||
| } | ||
| if missing { | ||
| missingCommits = append(missingCommits, commit) | ||
| } | ||
| } |
There was a problem hiding this comment.
Wondering why this is necessary given detectNewCommits()? This isn't moved from elsewhere like cherryPickAll below.
There was a problem hiding this comment.
While testing, I found it really useful to keep track of all the commits that need to be cherry-picked, even if some have already been picked. I added the centralRef flag to mark the start of our search, and this check to ensure we don't try to cherry-pick a commit more than once. This is not as necessary for the cherry-picks themselves, but was crucial for making sure the table of commits in the PR we send is full, even if the last invocation of this tool that pushes the PR did not do every single cherry-pick.
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
|
Yes, let's override it and move on - there's no world in which the content of this PR can influence that test... |
|
@stevekuznetsov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Speak of the devil... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, stevekuznetsov, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
This is a developer tool and doesn't impact anything in the payload. No bug required; manually adding jira/valid-bug label, as per conversation with @bparees. |
ncdc
added
the
jira/valid-bug
stevekuznetsov
changed the title
4 participants
No description provided.