Skip to content

OCPBUGS-3516: fix CSV unmarshaling error with custom unmarshaler with pretty errors (#1138)#557

Closed
grokspawn wants to merge 1 commit intoopenshift:masterfrom
grokspawn:pretty-errors
Closed

OCPBUGS-3516: fix CSV unmarshaling error with custom unmarshaler with pretty errors (#1138)#557
grokspawn wants to merge 1 commit intoopenshift:masterfrom
grokspawn:pretty-errors

Conversation

@grokspawn
Copy link
Copy Markdown
Contributor

@grokspawn grokspawn commented Aug 31, 2023

Also including a change to root .gitignore for test dockerfiles created during repo verification steps.

@grokspawn
fix CSV unmarshaling error with custom unmarshaler with pretty errors (…
576803e 
…#1138)

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 31, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 31, 2023

@grokspawn: This pull request references Jira Issue OCPBUGS-3516, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Also including a change to root .gitignore for test dockerfiles created during repo verification steps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@grokspawn
Copy link
Copy Markdown
Contributor Author

grokspawn commented Aug 31, 2023

/retest

@grokspawn
Copy link
Copy Markdown
Contributor Author

grokspawn commented Aug 31, 2023

/retest
Pod readiness was not something that this PR should have impacted.

@grokspawn
Copy link
Copy Markdown
Contributor Author

grokspawn commented Sep 1, 2023

/retest

@kuiwang02
Copy link
Copy Markdown
Contributor

kuiwang02 commented Sep 1, 2023

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Sep 1, 2023
stevekuznetsov
stevekuznetsov reviewed Sep 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a cherry-pick of an upstream commit?

Comment thread staging/operator-registry/alpha/declcfg/declcfg.go
"errors"
"fmt"

prettyunmarshaler "github.com/operator-framework/operator-registry/pkg/prettyunmarshaler"
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these import aliases are not needed

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Sep 1, 2023

Looks like it is a cherrypick. Let's get it in, in order, so future upstream syncs to master branch are not out-of-order.

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@grokspawn
Copy link
Copy Markdown
Contributor Author

grokspawn commented Sep 2, 2023

/test

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2023

@grokspawn: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e-gcp-console-olm
  • /test e2e-gcp-olm
  • /test e2e-gcp-ovn
  • /test e2e-upgrade
  • /test images
  • /test unit-api
  • /test unit-olm
  • /test unit-psm
  • /test unit-registry
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-gcp-olm-flaky

Use /test all to run all jobs.

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Copy Markdown
Contributor Author

grokspawn commented Sep 4, 2023

/retest

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Sep 5, 2023

@grokspawn It is likely not worth your time to re-test this, as it should be pulled in via a sync, not on it's own.

@grokspawn
Copy link
Copy Markdown
Contributor Author

grokspawn commented Sep 6, 2023

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 6, 2023

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Copy Markdown
Contributor

stevekuznetsov commented Sep 9, 2023

Now part of #562

@grokspawn
Copy link
Copy Markdown
Contributor Author

grokspawn commented Sep 11, 2023

Duplicate of #562

@grokspawn grokspawn closed this Sep 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 11, 2023

@grokspawn: This pull request references Jira Issue OCPBUGS-3516. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Also including a change to root .gitignore for test dockerfiles created during repo verification steps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn grokspawn deleted the pretty-errors branch October 21, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

@anik120 anik120 Awaiting requested review from anik120

@oceanc80 oceanc80 Awaiting requested review from oceanc80

1 more reviewer

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grokspawn @openshift-ci-robot @kuiwang02 @stevekuznetsov