OCPVE-674: feat: add annotations for capabilities feature#565
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
do-not-merge/hold
|
@eggfoobar: This pull request references OCPVE-674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @kevinrizza |
eggfoobar
force-pushed
the
add-capability-annotation
branch
from
0680382 to
3d876f6
Compare
|
@eggfoobar I think you'll need to go upstream and add these unless you can post-process them into all manifests in the generator script |
|
Thanks @stevekuznetsov, I wasn't able to find if we add the OCP specific annotations in the upstream projects, except in the |
|
Oops, sorry - missed the |
eggfoobar
force-pushed
the
add-capability-annotation
branch
2 times, most recently
from
bae504a to
6bfd2e0
Compare
|
/retest-required |
|
/unhold API Change merged in 🎉 |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@eggfoobar: This pull request references OCPVE-674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@eggfoobar: This pull request references OCPVE-674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
approved
|
@eggfoobar: This pull request references OCPVE-674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, ncdc, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
looks like there was a hiccup with cluster initialization on all those tests /retest |
|
/hold for now until we get CVO in update first. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@eggfoobar: This pull request references OCPVE-674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
This will fail by design until the CVO change is in @tmshort, so this can be left on hold until we're done updating some preliminary tests, I'll unhold this once that validation is done and we can allow the normal process to take shape here. |
adding annotation for capabilities to all manifest resources, this will allow users to make OLM an optional install Signed-off-by: ehila <ehila@redhat.com> fix: update generate manifests script Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
add-capability-annotation
branch
from
6bfd2e0 to
a74164e
Compare
|
/retest-required |
|
/unhold We should be all set with this now, CVO has been merged in and latest CI payloads are pulling in the change. |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/retest-required |
|
@eggfoobar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Revision a74164e was retested 3 times: holding |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/retest e2e-gcp-olm |
|
@tmshort: The
The following commands are available to trigger optional jobs:
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp-olm |
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
8 participants
adding annotation for capabilities to all manifest resources, this will allow users to make OLM an optional install
/hold
This is on hold until openshift/api#1589 is merged in.