Skip to content

[release-4.13] OCPBUGS-28228: Registry Pod Controller Flag#672

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-460-to-release-4.13
Jan 30, 2024
Merged

[release-4.13] OCPBUGS-28228: Registry Pod Controller Flag#672
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-460-to-release-4.13

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 25, 2024

This is an automated cherry-pick of #460

/assign dtfranz

@dtfranz
Registry Pod Controller Flag (#2928)
2e1176e 
Sets the marketplace pod's ownerreference to have `controller: true` to remove need for forceful node drain.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e5da837

Signed-off-by: Daniel Franz <dfranz@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 25, 2024
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 25, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-7431 has been cloned as Jira Issue OCPBUGS-28228. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-28228: Registry Pod Controller Flag

Details

In response to this:

This is an automated cherry-pick of #460

/assign dtfranz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.13] OCPBUGS-7431: Registry Pod Controller Flag [release-4.13] OCPBUGS-28228: Registry Pod Controller Flag Jan 25, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 25, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28228, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7431 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-7431 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #460

/assign dtfranz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dtfranz
Copy link
Copy Markdown
Contributor

dtfranz commented Jan 26, 2024

/test verify

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Jan 26, 2024

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-28228
/lgtm
/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci Bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jan 26, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 26, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28228, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7431 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-7431 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

This is an automated cherry-pick of #460

/assign dtfranz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@kevinrizza
Copy link
Copy Markdown
Member

kevinrizza commented Jan 26, 2024

/retest

1 similar comment
@ankitathomas
Copy link
Copy Markdown
Contributor

ankitathomas commented Jan 26, 2024

/retest

@oceanc80
Copy link
Copy Markdown
Contributor

oceanc80 commented Jan 26, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 26, 2024
@ankitathomas
Copy link
Copy Markdown
Contributor

ankitathomas commented Jan 26, 2024

/retest

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Jan 29, 2024

/test unit-api
/test verify

@dtfranz
Copy link
Copy Markdown
Contributor

dtfranz commented Jan 29, 2024

/test verify
/test unit-api

@wking
Copy link
Copy Markdown
Member

wking commented Jan 30, 2024

/retest-required

@kevinrizza
Copy link
Copy Markdown
Member

kevinrizza commented Jan 30, 2024

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 30, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit da84705 into openshift:release-4.13 Jan 30, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28228: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28228 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #460

/assign dtfranz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 30, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.13.0-202401302308.p0.gda84705.assembly.stream for distgit operator-lifecycle-manager.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 30, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-registry-container-v4.13.0-202401302308.p0.gda84705.assembly.stream for distgit operator-registry.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@anik120 anik120 Awaiting requested review from anik120

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@bandrade bandrade

@dtfranz dtfranz

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.