OCPBUGS-31547: UPSTREAM: <carry>: disable collect-profiles cronjob by kevinrizza · Pull Request #724 · openshift/operator-framework-olm

kevinrizza · 2024-03-29T13:33:22Z

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster

This has historically been difficult to explain to customers and at the moment provides tenuous value

openshift-ci-robot · 2024-03-29T13:33:25Z

@kevinrizza: This pull request explicitly references no jira issue.

Details

In response to this:

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster

This has historically been difficult to explain to customers and at the moment provides tenuous value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

everettraven

/lgtm

openshift-ci · 2024-03-29T14:35:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-03-29T15:20:31Z

/retest-required

Remaining retests: 0 against base HEAD c25e535 and 2 for PR HEAD cf59819 in total

openshift-ci-robot · 2024-03-29T15:49:56Z

@kevinrizza: This pull request references Jira Issue OCPBUGS-31547, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster

This has historically been difficult to explain to customers and at the moment provides tenuous value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-04-01T04:30:11Z

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-31547
/lgm
/label qe-approved

openshift-ci-robot · 2024-04-01T04:30:16Z

@kevinrizza: This pull request references Jira Issue OCPBUGS-31547, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster

This has historically been difficult to explain to customers and at the moment provides tenuous value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-04-01T04:30:23Z

/lgtm

openshift-ci-robot · 2024-04-01T05:20:22Z

/retest-required

Remaining retests: 0 against base HEAD b8e1c91 and 2 for PR HEAD d603561 in total

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster. For the microshift manifests, deleting the manifest entirely because there is no cvo for microshift Signed-off-by: Kevin Rizza <krizza@redhat.com>

grokspawn · 2024-04-01T18:56:32Z

/retest

kevinrizza · 2024-04-01T22:13:56Z

/retest

kevinrizza · 2024-04-02T14:14:39Z

/retest

these failures seem like cluster initialization issues, not something specific to this pull request

kevinrizza · 2024-04-03T00:51:38Z

/test e2e-gcp-ovn

grokspawn · 2024-04-03T14:09:37Z

/retest

tmshort · 2024-04-04T18:37:22Z

/retest

tmshort · 2024-04-04T18:38:57Z

We're just disabling? Not removing the code as well?

kevinrizza · 2024-04-04T18:43:18Z

We're just disabling? Not removing the code as well?

The intention is to prevent the cronjob from running so that this is no longer always happening on every cluster. It still seems useful to me as a potential data point if we want to do profiling on a specific customer cluster without having to give them special compiled bits

kevinrizza · 2024-04-05T17:53:52Z

/retest

perdasilva · 2024-04-08T08:55:56Z

/retest

perdasilva · 2024-04-08T09:12:52Z

/lgtm

perdasilva · 2024-04-08T09:46:31Z

/label backport-risk-assessed

openshift-ci-robot · 2024-04-08T11:29:53Z

/retest-required

Remaining retests: 0 against base HEAD 215fb45 and 2 for PR HEAD 1bd9676 in total

perdasilva · 2024-04-08T15:38:10Z

Failure looks legit:

{  fail [github.com/openshift/origin/test/extended/operators/certs.go:115]: Unexpected error:
    <errors.aggregate | len:1, cap:1>: 
    secrets/pprof-cert[openshift-operator-lifecycle-manager] MISSING tls.crt content
    
    [
        <*errors.errorString | 0xc001a936e0>{
            s: "secrets/pprof-cert[openshift-operator-lifecycle-manager] MISSING tls.crt content\n",
        },
    ]
occurred
Ginkgo exit error 1: exit with code 1}

openshift-ci-robot · 2024-04-09T04:07:52Z

/retest-required

Remaining retests: 0 against base HEAD 279155f and 1 for PR HEAD 1bd9676 in total

openshift-ci-robot · 2024-04-12T08:51:07Z

/retest-required

Remaining retests: 0 against base HEAD 62c1ae8 and 0 for PR HEAD 1bd9676 in total

openshift-ci · 2024-04-12T11:02:29Z

@kevinrizza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	`1bd9676`	link	true	`/test e2e-gcp-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-04-12T11:51:09Z

/hold

Revision 1bd9676 was retested 3 times: holding

kevinrizza · 2024-04-12T12:52:20Z

closing in favor of #730

openshift-ci-robot · 2024-04-12T12:52:28Z

@kevinrizza: This pull request references Jira Issue OCPBUGS-31547. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster

This has historically been difficult to explain to customers and at the moment provides tenuous value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 29, 2024

openshift-ci Bot requested review from anik120 and dinhxuanvu March 29, 2024 13:33

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024

everettraven approved these changes Mar 29, 2024

View reviewed changes

openshift-ci Bot assigned everettraven Mar 29, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024

kevinrizza force-pushed the disable-collectprofiles branch from cf59819 to d603561 Compare March 29, 2024 15:36

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024

kevinrizza changed the title ~~NO-ISSUE: UPSTREAM: <carry>: disable collect-profiles cronjob~~ OCPBUGS-31547: UPSTREAM: <carry>: disable collect-profiles cronjob Mar 29, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 29, 2024

openshift-ci Bot requested a review from jianzhangbjz March 29, 2024 15:49

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Apr 1, 2024

openshift-ci Bot assigned jianzhangbjz Apr 1, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024

kevinrizza force-pushed the disable-collectprofiles branch from d603561 to 1bd9676 Compare April 1, 2024 15:39

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024

openshift-ci Bot assigned perdasilva Apr 8, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 8, 2024

openshift-ci Bot assigned bandrade, emmajiafan, KeenonLee, kuiwang02 and Xia-Zhao-rh Apr 8, 2024

perdasilva mentioned this pull request Apr 10, 2024

[WIP] OCPBUGS-31547: UPSTREAM: <carry>: disable collect-profiles cronjob #730

Closed

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024

kevinrizza closed this Apr 12, 2024

Conversation

kevinrizza commented Mar 29, 2024

Uh oh!

openshift-ci-robot commented Mar 29, 2024

Uh oh!

everettraven left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Mar 29, 2024

Uh oh!

openshift-ci-robot commented Mar 29, 2024

Uh oh!

openshift-ci-robot commented Mar 29, 2024

Uh oh!

jianzhangbjz commented Apr 1, 2024

Uh oh!

openshift-ci-robot commented Apr 1, 2024

Uh oh!

jianzhangbjz commented Apr 1, 2024

Uh oh!

openshift-ci-robot commented Apr 1, 2024

Uh oh!

grokspawn commented Apr 1, 2024

Uh oh!

kevinrizza commented Apr 1, 2024

Uh oh!

kevinrizza commented Apr 2, 2024

Uh oh!

kevinrizza commented Apr 3, 2024

Uh oh!

grokspawn commented Apr 3, 2024

Uh oh!

tmshort commented Apr 4, 2024

Uh oh!

tmshort commented Apr 4, 2024

Uh oh!

kevinrizza commented Apr 4, 2024

Uh oh!

kevinrizza commented Apr 5, 2024

Uh oh!

perdasilva commented Apr 8, 2024

Uh oh!

perdasilva commented Apr 8, 2024

Uh oh!

perdasilva commented Apr 8, 2024

Uh oh!

openshift-ci-robot commented Apr 8, 2024

Uh oh!

perdasilva commented Apr 8, 2024

Uh oh!

openshift-ci-robot commented Apr 9, 2024

Uh oh!

openshift-ci-robot commented Apr 12, 2024

Uh oh!

openshift-ci Bot commented Apr 12, 2024

Uh oh!

openshift-ci-robot commented Apr 12, 2024

Uh oh!

kevinrizza commented Apr 12, 2024

Uh oh!

openshift-ci-robot commented Apr 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants