[release-4.14] OCPBUGS-36949: [CARRY] perform operator apiService certificate validity checks directly by ankitathomas · Pull Request #821 · openshift/operator-framework-olm

ankitathomas · 2024-07-12T20:12:17Z

Manual cherry-pick of #819 to 4.14

openshift-ci-robot · 2024-07-12T20:12:21Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-36949, which is invalid:

expected Jira Issue OCPBUGS-36949 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #819 to 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-07-12T20:12:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [ankitathomas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The issue for this is open for years and it's not super interesting to go debug it. The test threads will exit when the test process does. Having teardown fail means none of the other tests run for me. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: b683c28b31ad12f8acb8f7fd4d7beb85c74a751f

…cks directly (#3217) * perform operator apiService certificate validity checks directly Signed-off-by: Ankita Thomas <ankithom@redhat.com> * use sets to track certs to install, revert to checking for installPlan timeouts after API availability checks, add service FQDN to list of hostnames. Signed-off-by: Ankita Thomas <ankithom@redhat.com> --------- Signed-off-by: Ankita Thomas <ankithom@redhat.com>

perdasilva · 2024-07-16T11:35:06Z

/retest

ankitathomas · 2024-07-17T16:54:15Z

/retest

ankitathomas · 2024-07-19T10:18:58Z

/retest

dtfranz · 2024-07-19T18:57:28Z

/retest

kevinrizza · 2024-07-22T14:52:23Z

/retest

dtfranz · 2024-07-22T18:17:05Z

/jira refresh
/retest

openshift-ci-robot · 2024-07-22T18:17:12Z

@dtfranz: This pull request references Jira Issue OCPBUGS-36949, which is valid. The bug has been moved to the POST state.

9 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-36813 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent bug Jira Issue OCPBUGS-36813 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-36813 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
dependent Jira Issue OCPBUGS-36813 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-07-23T02:43:37Z

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-36949
/label qe-approved
/label cherry-pick-apporved

openshift-ci · 2024-07-23T02:43:40Z

@jianzhangbjz: The label(s) /label cherry-pick-apporved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-36949
/label qe-approved
/label cherry-pick-apporved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2024-07-23T02:43:43Z

@ankitathomas: This pull request references Jira Issue OCPBUGS-36949, which is valid.

9 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-36813 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent bug Jira Issue OCPBUGS-36813 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-36813 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
dependent Jira Issue OCPBUGS-36813 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

Manual cherry-pick of #819 to 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-07-23T02:43:48Z

/lgtm

jianzhangbjz · 2024-07-23T02:46:10Z

/label cherry-pick-approved

kevinrizza · 2024-07-30T19:05:46Z

/lgtm

ankitathomas · 2024-07-30T19:18:53Z

/retest

dtfranz · 2024-07-30T22:39:36Z

/retest

m1kola · 2024-07-31T04:33:24Z

/retest

rtheis · 2024-07-31T15:13:39Z

/retest-required

ankitathomas · 2024-08-01T13:45:18Z

/retest

ankitathomas · 2024-08-01T17:57:13Z

/retest

Some of the e2e loops are a bit flakey, make them more robust * Retry on certain errors * Use Eventually() consistently (avoid wait.Poll()) * Clarify logging * Reduce some logging * Change csvExists() to waitForCsvToDelete(), as that's how it's used * Change awaitCSV() to fetchCSV() Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: e5f7320f29ee4e9def114d6dcc1d22b4c7bb2b0d

openshift-ci · 2024-08-02T21:58:47Z

@ankitathomas: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sdodson · 2024-08-06T19:35:19Z

@kevinrizza can we get a fresh review given recent changes?

perdasilva · 2024-08-07T00:29:32Z

/lgtm
/label backport-risk-assessed

openshift-ci-robot · 2024-08-07T00:34:17Z

@ankitathomas: Jira Issue OCPBUGS-36949: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#821

Jira Issue OCPBUGS-36949 has been moved to the MODIFIED state.

Details

In response to this:

Manual cherry-pick of #819 to 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-08-07T06:33:09Z

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202408070332.p0.gb1d51eb.assembly.stream.el8.
All builds following this will include this PR.

openshift-bot · 2024-08-07T06:36:08Z

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.14.0-202408070332.p0.gb1d51eb.assembly.stream.el8.
All builds following this will include this PR.

rtheis · 2024-08-09T10:37:55Z

@ankitathomas are there plans to cherry-pick this to the 4.12 and 4.13 releases?

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 12, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 12, 2024

openshift-ci Bot requested review from dinhxuanvu and kevinrizza July 12, 2024 20:12

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024

ankitathomas force-pushed the OCP25341-4.14 branch from a5695a8 to 6dab033 Compare July 12, 2024 20:30

stevekuznetsov and others added 2 commits July 16, 2024 01:40

ankitathomas force-pushed the OCP25341-4.14 branch from 6dab033 to e705fec Compare July 16, 2024 05:40

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 22, 2024

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jul 23, 2024

openshift-ci Bot assigned jianzhangbjz Jul 23, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 23, 2024

openshift-ci Bot assigned kevinrizza Jul 30, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024

ankitathomas force-pushed the OCP25341-4.14 branch from 38e4ab9 to 18faa2d Compare August 2, 2024 07:35

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024

ankitathomas force-pushed the OCP25341-4.14 branch from 18faa2d to 83af49d Compare August 2, 2024 19:07

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 7, 2024

openshift-ci Bot assigned bandrade, emmajiafan, KeenonLee, kuiwang02, Xia-Zhao-rh and perdasilva Aug 7, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024

openshift-merge-bot Bot merged commit b1d51eb into openshift:release-4.14 Aug 7, 2024

ankitathomas mentioned this pull request Aug 9, 2024

[release-4.13] OCPBUGS-38254: [CARRY] perform operator apiService certificate validity checks directly #836

Merged

Conversation

ankitathomas commented Jul 12, 2024

Uh oh!

openshift-ci-robot commented Jul 12, 2024

Uh oh!

openshift-ci Bot commented Jul 12, 2024

Uh oh!

perdasilva commented Jul 16, 2024

Uh oh!

ankitathomas commented Jul 17, 2024

Uh oh!

ankitathomas commented Jul 19, 2024

Uh oh!

dtfranz commented Jul 19, 2024

Uh oh!

kevinrizza commented Jul 22, 2024

Uh oh!

dtfranz commented Jul 22, 2024

Uh oh!

openshift-ci-robot commented Jul 22, 2024

Uh oh!

jianzhangbjz commented Jul 23, 2024

Uh oh!

openshift-ci Bot commented Jul 23, 2024

Uh oh!

openshift-ci-robot commented Jul 23, 2024

Uh oh!

jianzhangbjz commented Jul 23, 2024

Uh oh!

jianzhangbjz commented Jul 23, 2024

Uh oh!

kevinrizza commented Jul 30, 2024

Uh oh!

ankitathomas commented Jul 30, 2024

Uh oh!

dtfranz commented Jul 30, 2024

Uh oh!

m1kola commented Jul 31, 2024

Uh oh!

rtheis commented Jul 31, 2024

Uh oh!

ankitathomas commented Aug 1, 2024

Uh oh!

ankitathomas commented Aug 1, 2024

Uh oh!

openshift-ci Bot commented Aug 2, 2024

Uh oh!

sdodson commented Aug 6, 2024

Uh oh!

perdasilva commented Aug 7, 2024

Uh oh!

openshift-ci-robot commented Aug 7, 2024

Uh oh!

openshift-bot commented Aug 7, 2024

Uh oh!

openshift-bot commented Aug 7, 2024

Uh oh!

rtheis commented Aug 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants