OCPBUGS-30333: Move Helm to bingo dep and update it by bentito · Pull Request #837 · openshift/operator-framework-olm

bentito · 2024-08-09T18:14:35Z

We're adding bingo to the top level of this monorepo. In doing this we are also changing the dependency to a version of Helm that is free of the target bug.

Actual files in need of review:
.bingo/*
Makefile
go.mod
~~go.sum~~
scripts/generate_crds_manifests.sh
tools.go

openshift-ci-robot · 2024-08-09T18:14:40Z

@bentito: This pull request references Jira Issue OCPBUGS-30333, which is invalid:

expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We're adding bingo to the top level of this monorepo. In doing this we are also changing the dependency to a version of Helm that is free of the target bug.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bentito · 2024-08-09T18:17:30Z

/jira refresh

openshift-ci-robot · 2024-08-09T18:17:33Z

@bentito: This pull request references Jira Issue OCPBUGS-30333, which is invalid:

expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bentito · 2024-08-09T18:18:40Z

/jira refresh

openshift-ci-robot · 2024-08-09T18:18:43Z

@bentito: This pull request references Jira Issue OCPBUGS-30333, which is invalid:

expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2024-08-13T16:31:08Z

/jira refresh

openshift-ci-robot · 2024-08-13T16:31:13Z

@perdasilva: This pull request references Jira Issue OCPBUGS-30333, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

grokspawn · 2024-08-13T18:43:09Z

lgtm, but I'll just stick one label on here in case someone else wants to 👀 today. Otherwise I'll try to circle back around and merge.

/approve

openshift-ci · 2024-08-13T18:43:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bentito, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

grokspawn · 2024-08-14T20:59:46Z

/lgtm

Signed-off-by: Brett Tofel <btofel@redhat.com>

grokspawn · 2024-08-15T02:58:12Z

/lgtm
/label tide/merge-method-squash

openshift-ci-robot · 2024-08-15T03:46:40Z

/retest-required

Remaining retests: 0 against base HEAD caef475 and 2 for PR HEAD 4e3cd64 in total

openshift-ci · 2024-08-15T06:07:39Z

@bentito: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-olm-flaky	`4e3cd64`	link	false	`/test e2e-gcp-olm-flaky`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-08-15T06:11:45Z

@bentito: Jira Issue OCPBUGS-30333: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#837

Jira Issue OCPBUGS-30333 has been moved to the MODIFIED state.

Details

In response to this:

We're adding bingo to the top level of this monorepo. In doing this we are also changing the dependency to a version of Helm that is free of the target bug.

Actual files in need of review:
.bingo/*
Makefile
go.mod
~~go.sum~~
scripts/generate_crds_manifests.sh
tools.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-08-15T10:14:12Z

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.18.0-202408150943.p0.g7915649.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-08-15T10:17:12Z

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.18.0-202408150943.p0.g7915649.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-08-15T10:23:13Z

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.18.0-202408150943.p0.g7915649.assembly.stream.el9.
All builds following this will include this PR.

m1kola · 2024-09-05T11:16:36Z

/jira refresh

openshift-ci-robot · 2024-09-05T11:16:39Z

@m1kola: Jira Issue OCPBUGS-30333 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

* Add bingo for Helm dep * Add bingo for Helm dep - vendor changes Signed-off-by: Brett Tofel <btofel@redhat.com> * Rm debug statement Signed-off-by: Brett Tofel <btofel@redhat.com> * Sync bingo go version with toolchain go version Signed-off-by: Brett Tofel <btofel@redhat.com> * Some Go debugging lines to debug helm bin path Signed-off-by: Brett Tofel <btofel@redhat.com> * Add helm dependency to verify target Signed-off-by: Brett Tofel <btofel@redhat.com> * Move down the bingo include to protect early defs Signed-off-by: Brett Tofel <btofel@redhat.com> --------- Signed-off-by: Brett Tofel <btofel@redhat.com>

openshift-ci Bot requested review from dinhxuanvu and tmshort August 9, 2024 18:15

This was referenced Aug 9, 2024

OCPBUGS-30333: Remove Helm #807

Closed

OCPBUGS-30333: Bump to Helm 3.15.0 #786

Closed

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 13, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 13, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2024

openshift-ci Bot assigned grokspawn Aug 14, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024

bentito added 7 commits August 14, 2024 19:48

Add bingo for Helm dep

fe1831c

Add bingo for Helm dep - vendor changes

09c5ac3

Signed-off-by: Brett Tofel <btofel@redhat.com>

Rm debug statement

4e67035

Signed-off-by: Brett Tofel <btofel@redhat.com>

Sync bingo go version with toolchain go version

55fe6cb

Signed-off-by: Brett Tofel <btofel@redhat.com>

Some Go debugging lines to debug helm bin path

52feb84

Signed-off-by: Brett Tofel <btofel@redhat.com>

Add helm dependency to verify target

c489998

Signed-off-by: Brett Tofel <btofel@redhat.com>

Move down the bingo include to protect early defs

4e3cd64

Signed-off-by: Brett Tofel <btofel@redhat.com>

bentito force-pushed the bingoify-monorepo branch from 1d3453f to 4e3cd64 Compare August 14, 2024 23:58

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2024

openshift-ci Bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm Indicates that a PR is ready to be merged. labels Aug 15, 2024

openshift-merge-bot Bot merged commit 7915649 into openshift:master Aug 15, 2024

Conversation

bentito commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 9, 2024

Uh oh!

bentito commented Aug 9, 2024

Uh oh!

openshift-ci-robot commented Aug 9, 2024

Uh oh!

bentito commented Aug 9, 2024

Uh oh!

openshift-ci-robot commented Aug 9, 2024

Uh oh!

perdasilva commented Aug 13, 2024

Uh oh!

openshift-ci-robot commented Aug 13, 2024

Uh oh!

grokspawn commented Aug 13, 2024

Uh oh!

openshift-ci Bot commented Aug 13, 2024

Uh oh!

grokspawn commented Aug 14, 2024

Uh oh!

grokspawn commented Aug 15, 2024

Uh oh!

openshift-ci-robot commented Aug 15, 2024

Uh oh!

openshift-ci Bot commented Aug 15, 2024

Uh oh!

openshift-ci-robot commented Aug 15, 2024

Uh oh!

openshift-bot commented Aug 15, 2024

Uh oh!

openshift-bot commented Aug 15, 2024

Uh oh!

openshift-bot commented Aug 15, 2024

Uh oh!

m1kola commented Sep 5, 2024

Uh oh!

openshift-ci-robot commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bentito commented Aug 9, 2024 •

edited

Loading