Skip to content

[release-4.16] OCPBUGS-44802: fix: call TokenRequest API when service account token secret is missing#900

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.16from
openshift-cherrypick-robot:cherry-pick-898-to-release-4.16
Nov 21, 2024
Merged

[release-4.16] OCPBUGS-44802: fix: call TokenRequest API when service account token secret is missing#900
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.16from
openshift-cherrypick-robot:cherry-pick-898-to-release-4.16

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 20, 2024

This is an automated cherry-pick of #898

/assign grokspawn

@OchiengEd
fix: call TokenRequest API when service account token secret is missi…
b349a38 
…ng (#3377)

* fix: call TokenRequest API when service account token secret is missing

Beyond Kubernetes 1.22, the service account token secret is not
automatically, created. Therefore, when OLM is not able to find the
service account token secret, it should request one from the k8s api
server.

Ref: https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/#manual-secret-management-for-serviceaccounts

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>

* fix: return error

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>

* handle error when creating sa token from TokenRequest API fails

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>

* move return from inner loop

Move the return to line 48. This will ensure a value is returned whether
we successully create a service account token from the TokenRequest API or get an error

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>

---------

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e20778cbb590f82dbe9cba500e98e7317222e5b5
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 20, 2024
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 20, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44760 has been cloned as Jira Issue OCPBUGS-44802. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-44802: fix: call TokenRequest API when service account token secret is missing

Details

In response to this:

This is an automated cherry-pick of #898

/assign grokspawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.16] OCPBUGS-44760: fix: call TokenRequest API when service account token secret is missing [release-4.16] OCPBUGS-44802: fix: call TokenRequest API when service account token secret is missing Nov 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 20, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 20, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-44802, which is invalid:

  • expected dependent Jira Issue OCPBUGS-44760 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #898

/assign grokspawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from oceanc80 and tmshort November 20, 2024 15:03
@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Nov 20, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 20, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 20, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grokspawn
Copy link
Copy Markdown
Contributor

grokspawn commented Nov 20, 2024

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@grokspawn
Copy link
Copy Markdown
Contributor

grokspawn commented Nov 20, 2024

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 20, 2024

@grokspawn: This pull request references Jira Issue OCPBUGS-44802, which is invalid:

  • expected dependent Jira Issue OCPBUGS-44760 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Xia-Zhao-rh
Copy link
Copy Markdown
Contributor

Xia-Zhao-rh commented Nov 21, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 21, 2024
@Xia-Zhao-rh
Copy link
Copy Markdown
Contributor

Xia-Zhao-rh commented Nov 21, 2024

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Nov 21, 2024
@Xia-Zhao-rh
Copy link
Copy Markdown
Contributor

Xia-Zhao-rh commented Nov 21, 2024

/lgtm

@Xia-Zhao-rh
Copy link
Copy Markdown
Contributor

Xia-Zhao-rh commented Nov 21, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 21, 2024

@Xia-Zhao-rh: This pull request references Jira Issue OCPBUGS-44802, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-44760 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-44760 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from Xia-Zhao-rh November 21, 2024 03:04
@openshift-merge-bot openshift-merge-bot Bot merged commit d718c4c into openshift:release-4.16 Nov 21, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 21, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44802: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44802 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #898

/assign grokspawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 21, 2024

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.16.0-202411210334.p0.gd718c4c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 21, 2024

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.16.0-202411210334.p0.gd718c4c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 21, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.16.0-202411210503.p0.gd718c4c.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@tmshort tmshort Awaiting requested review from tmshort

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

Assignees

@bandrade bandrade

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

@grokspawn grokspawn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.