Skip to content

OCPBUGS-52930,OCPBUGS-52924,OCPBUGS-52923: pin go-jose/v4@v4.0.5#993

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
anik120:followup-OCPBUGS-52923
Apr 24, 2025
Merged

OCPBUGS-52930,OCPBUGS-52924,OCPBUGS-52923: pin go-jose/v4@v4.0.5#993
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
anik120:followup-OCPBUGS-52923

Conversation

@anik120
Copy link
Copy Markdown
Contributor

@anik120 anik120 commented Apr 24, 2025

d3160ca only changed the stagin directory, and not what is actually being vendor-ed in. This PR modifies the top level go.mod file and ensure the correct version of the package is being vendored in for https://bugzilla.redhat.com/show_bug.cgi?id=2347423

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2025

@anik120: No Jira issue with key CVE-2025 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

d3160ca only changed the stagin directory, and not what is actually being vendor-ed in. This PR modifies the top level go.mod file and ensure the correct version of the package is being vendored in for https://bugzilla.redhat.com/show_bug.cgi?id=2347423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2025
@anik120 anik120 force-pushed the followup-OCPBUGS-52923 branch from 43bc298 to 3161f02 Compare April 24, 2025 14:14
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2025
@anik120
CVE-2025-27144: pin go-jose/v4@v4.0.5
b01e25f 
openshift@d3160ca only changed the stagin directory, and not what
is actually being vendor-ed in. This PR modifies the top level
go.mod file and ensure the correct version of the package is being
vendored in for https://bugzilla.redhat.com/show_bug.cgi?id=2347423
@anik120 anik120 force-pushed the followup-OCPBUGS-52923 branch from 3161f02 to b01e25f Compare April 24, 2025 14:39
tmshort
tmshort approved these changes Apr 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@anik120 anik120 changed the title CVE-2025-27144: pin go-jose/v4@v4.0.5 OCPBUGS-52923: pin go-jose/v4@v4.0.5 Apr 24, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 24, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2025

@anik120: This pull request references Jira Issue OCPBUGS-52923, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bandrade@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

d3160ca only changed the stagin directory, and not what is actually being vendor-ed in. This PR modifies the top level go.mod file and ensure the correct version of the package is being vendored in for https://bugzilla.redhat.com/show_bug.cgi?id=2347423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 24, 2025
@anik120
Copy link
Copy Markdown
Contributor Author

anik120 commented Apr 24, 2025

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2025

@anik120: This pull request references Jira Issue OCPBUGS-52923, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bandrade@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 3eee029 and 2 for PR HEAD b01e25f in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2025

@anik120: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b01e25f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 3c3b230 into openshift:main Apr 24, 2025
14 of 15 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2025

@anik120: Jira Issue OCPBUGS-52923: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52923 has been moved to the MODIFIED state.

Details

In response to this:

d3160ca only changed the stagin directory, and not what is actually being vendor-ed in. This PR modifies the top level go.mod file and ensure the correct version of the package is being vendored in for https://bugzilla.redhat.com/show_bug.cgi?id=2347423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 25, 2025

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.20.0-202504250541.p0.g3c3b230.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 25, 2025

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.20.0-202504250541.p0.g3c3b230.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 25, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.19.0-202504250617.p0.g3c3b230.assembly.stream.el9.
All builds following this will include this PR.

@anik120 anik120 changed the title OCPBUGS-52923: pin go-jose/v4@v4.0.5 OCPBUGS-52924,OCPBUGS-52923: pin go-jose/v4@v4.0.5 Apr 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025

@anik120: Jira Issue OCPBUGS-52924: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52924 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-52923 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

d3160ca only changed the stagin directory, and not what is actually being vendor-ed in. This PR modifies the top level go.mod file and ensure the correct version of the package is being vendored in for https://bugzilla.redhat.com/show_bug.cgi?id=2347423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anik120 anik120 changed the title OCPBUGS-52924,OCPBUGS-52923: pin go-jose/v4@v4.0.5 OCPBUGS-52930,OCPBUGS-52924,OCPBUGS-52923: pin go-jose/v4@v4.0.5 Apr 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2025

@anik120: Jira Issue OCPBUGS-52930: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52930 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-52924 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Jira Issue OCPBUGS-52923 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

d3160ca only changed the stagin directory, and not what is actually being vendor-ed in. This PR modifies the top level go.mod file and ensure the correct version of the package is being vendored in for https://bugzilla.redhat.com/show_bug.cgi?id=2347423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@thetechnick thetechnick Awaiting requested review from thetechnick

1 more reviewer

@tmshort tmshort tmshort approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anik120 @openshift-ci-robot @openshift-bot @tmshort @openshift-merge-robot