OPRUN-4574: UPSTREAM: <carry>: Disable upstream TLSProfile tests by tmshort · Pull Request #702 · openshift/operator-framework-operator-controller

tmshort · 2026-04-18T02:32:26Z

This should allow downstream sync to succeed.

Summary by CodeRabbit

Chores
- Updated end-to-end test configuration to derive test tag filters from an exported variable instead of a hardcoded string, improving flexibility for downstream test runs and making it easier to adjust which tests are included or excluded during execution.

openshift-ci-robot · 2026-04-18T02:32:30Z

@tmshort: This pull request references OPRUN-4574 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This should allow downstream sync to succeed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-18T02:32:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 85e29967-bda9-4dfb-a847-a8f2352aebb1

📥 Commits

Reviewing files that changed from the base of the PR and between b8027e7 and 79cfc14.

📒 Files selected for processing (1)

openshift/Makefile

🚧 Files skipped from review as they are similar to previous changes (1)

openshift/Makefile

Walkthrough

The test-e2e Makefile target now uses a new exported variable DOWNSTREAM_GODOG_FLAGS for the Godog tag expression (~@mirrored-registry && ~@TLSProfile) instead of a hardcoded ~@mirrored-registry string; command structure and other flags remain unchanged.

Changes

Cohort / File(s)	Summary
Makefile Configuration `openshift/Makefile`	Added exported variable `DOWNSTREAM_GODOG_FLAGS` set to `~@mirrored-registry && ~@TLSProfile`; `test-e2e` target updated to pass `--godog.tags="$(DOWNSTREAM_GODOG_FLAGS)"` to `go test`. No other flags or command structure changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: disabling TLSProfile tests by adding an exclusion filter (~@TLSProfile) to the Godog flags in the Makefile.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	PR only adds Makefile variable for test filtering via Godog tags and does not modify any Ginkgo test name definitions, so no dynamic information is introduced into test names.
Test Structure And Quality	✅ Passed	This custom check is not applicable as the PR only modifies the Makefile and does not involve changes to Ginkgo test code, Gherkin feature files, or test implementations.
Microshift Test Compatibility	✅ Passed	This pull request modifies the openshift/Makefile to update DOWNSTREAM_GODOG_FLAGS from ~@mirrored-registry to ~@mirrored-registry && ~@TLSProfile, skipping tests marked with `@TLSProfile` tags. No new Ginkgo e2e tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request does not add new Ginkgo e2e tests; it only modifies openshift/Makefile to add DOWNSTREAM_GODOG_FLAGS variable filtering `@TLSProfile` tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only Makefile change for test infrastructure filtering without modifying production operator code, deployment manifests, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR modifies only openshift/Makefile to add DOWNSTREAM_GODOG_FLAGS variable; no Go source code modifications present, so OTE Binary Stdout Contract check does not apply.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies Makefile to filter Godog/BDD tests, not adding new Ginkgo e2e tests. Custom check explicitly applies only when new Ginkgo tests are added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@openshift/Makefile`:
- Around line 44-50: The exported variable name DOWNSTREAL_GODOG_FLAGS in the
Makefile is misspelled and does not match the variable used in the test-e2e
target (DOWNSTREAM_GODOG_FLAGS); fix the typo by renaming the export to
DOWNSTREAM_GODOG_FLAGS so the exported value (including the ~@TLSProfile
exclusion) is used when invoking go test
--godog.tags="$(DOWNSTREAM_GODOG_FLAGS)". Update the export line rather than the
usage in test-e2e to preserve intent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d1ebb0d-3e1a-4293-8b4a-be9cc66b6b90

📥 Commits

Reviewing files that changed from the base of the PR and between 30ae9b2 and b8027e7.

📒 Files selected for processing (1)

openshift/Makefile

Signed-off-by: Todd Short <todd.short@me.com>

camilamacedo86 · 2026-04-20T15:15:19Z

/lgtm

The change seems fine
Assuming that pass in all tests OK.

openshift-ci · 2026-04-20T17:32:53Z

@tmshort: This PR was included in a payload test run from #701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2026-04-20T17:44:39Z

@tmshort: This PR was included in a payload test run from #701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2026-04-20T18:01:16Z

@tmshort: This PR was included in a payload test run from #701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2026-04-20T18:02:53Z

@tmshort: This PR was included in a payload test run from #701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

tmshort · 2026-04-20T19:05:11Z

/testwith openshift/operator-framework-operator-controller/main/openshift-e2e-aws #701

tmshort · 2026-04-20T20:54:53Z

The upstream tests succeeded in the /testwith

INFO[2026-04-20T20:07:43Z] Running step openshift-e2e-aws-upstream-e2e. 
INFO[2026-04-20T20:11:21Z] Step openshift-e2e-aws-upstream-e2e succeeded after 3m37s.

camilamacedo86

/lgtm

We need @bandrade help on this one.
Thank you

openshift-ci · 2026-04-21T07:45:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

perdasilva · 2026-04-21T08:07:55Z

/verified

openshift-ci-robot · 2026-04-21T08:07:58Z

@perdasilva: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2026-04-21T13:24:57Z

/verified bypass

this PR disables certain upstream tests - CI passes lgtm

openshift-ci-robot · 2026-04-21T13:25:10Z

@perdasilva: The verified label has been added.

Details

In response to this:

/verified bypass

this PR disables certain upstream tests - CI passes lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-21T16:41:30Z

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2026

openshift-ci Bot requested review from camilamacedo86 and oceanc80 April 18, 2026 02:32

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2026

coderabbitai Bot reviewed Apr 18, 2026

View reviewed changes

Comment thread openshift/Makefile Outdated

UPSTREAM: <carry>: Disable upstream TLSProfile tests

79cfc14

Signed-off-by: Todd Short <todd.short@me.com>

tmshort force-pushed the disable-tls-upstream-tls-tests branch from b8027e7 to 79cfc14 Compare April 20, 2026 13:57

camilamacedo86 approved these changes Apr 20, 2026

View reviewed changes

openshift-ci Bot assigned camilamacedo86 Apr 20, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026

tmshort mentioned this pull request Apr 20, 2026

NO-ISSUE: Synchronize From Upstream Repositories #701

Merged

camilamacedo86 approved these changes Apr 21, 2026

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 21, 2026

openshift-merge-bot Bot merged commit b5bda4a into openshift:main Apr 21, 2026
15 checks passed

Conversation

tmshort commented Apr 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Apr 18, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

camilamacedo86 commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Apr 20, 2026

Uh oh!

openshift-ci Bot commented Apr 20, 2026

Uh oh!

openshift-ci Bot commented Apr 20, 2026

Uh oh!

openshift-ci Bot commented Apr 20, 2026

Uh oh!

tmshort commented Apr 20, 2026

Uh oh!

tmshort commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Apr 21, 2026

Uh oh!

perdasilva commented Apr 21, 2026

Uh oh!

openshift-ci-robot commented Apr 21, 2026

Uh oh!

perdasilva commented Apr 21, 2026

Uh oh!

openshift-ci-robot commented Apr 21, 2026

Uh oh!

openshift-ci Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tmshort commented Apr 18, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Apr 18, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Apr 18, 2026 •

edited

Loading

camilamacedo86 commented Apr 20, 2026 •

edited

Loading

tmshort commented Apr 20, 2026 •

edited

Loading