Add name length validations to project creation

[jcantrill]

Ran into an issue where I was able to create project 'foo', but unable to push to the local docker registry because the name was too short. Add name length validations to project creation, server-side, and possibly to the client create project command.

Per @ncdc ref as the current restrictions are in flux:
https://github.com/docker/distribution/blob/master/registry/api/v2/names.go#L16
https://github.com/docker/distribution/blob/master/registry/api/v2/names.go#L20
moby/moby#10392 (comment)
distribution/distribution#241

@derekwaynecarr This would need to go upstream?

[derekwaynecarr]

Origin will proxy the namespace create request in Kube, so in theory, we can provide our own more restrictive validation once the docker registry constraints are better known. In practice, I am not a fan of needing to align project name validation with docker registry validation rules.

Is it not possible to adapt a project name to a valid docker registry name?

For example, if the project name is too short, can we not pad it when its used on the registry side?

[ncdc]

@derekwaynecarr we could do that. However, if someone wanted to pull from/push to their image repository in our registry, they'd have to know the padding rules, as docker pull registry.openshift.com/a/myapp will fail.

[derekwaynecarr]

If the padding rule is to meet a min-length of 2, it's not a lot of padding, so I am less concerned there.

I am more concerned on the max length constraint of 30 characters.

Kube restricts at a much higher level:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/util/validation.go#L52

[ncdc]

I'm not overly concerned about 30; we're working with Docker to get that increased.

[derekwaynecarr]

So if we need to provide our own more restrictive validation that a project has a length between 2 and 30 characters, we can do that, but it limits our ability to expose any existing namespaces in Kuberentes as projects if/when Origin runs as pod on an existing Kubernetes cluster.

[liggitt]

@ncdc what did the length requirements end up being for the v2 registry?

[ncdc]

@liggitt a Docker image repository is made up of 1 or more components separated by slashes. Each component must be at least 2 characters, and the first character of each component must be alphanumeric. The total length of an image repository's name, including slashes, must be <= 255 characters.

[ncdc]

See https://github.com/docker/distribution/blob/master/registry/api/v2/names.go for the impl.

[liggitt]

Also see https://bugzilla.redhat.com/show_bug.cgi?id=1190052

[derekwaynecarr]

We proxy project creation so in theory we could further restrict validation.

Sent from my iPhone

On May 16, 2015, at 11:02 PM, Jordan Liggitt notifications@github.com wrote:

Also see https://bugzilla.redhat.com/show_bug.cgi?id=1190052

—
Reply to this email directly or view it on GitHub.