Skip to content

Fix several typos#1018

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
rhcarvalho:typokiller
Feb 16, 2015
Merged

Fix several typos#1018
openshift-bot merged 1 commit intoopenshift:masterfrom
rhcarvalho:typokiller

Conversation

@rhcarvalho
Copy link
Contributor

Hi everyone! I used OpenShift Origin's repo as my first test target for typokiller.

Happy to see just a small amount of typos, kudos to you all! Great job!

@jhadvig
Copy link
Member

jhadvig commented Feb 14, 2015

@rhcarvalho thanks for fixing this. Could you please squash into one commit, since basically both commits are just fixing typos ?

@rhcarvalho
Copy link
Contributor Author

@jhadvig I had it separate because the capitalization cases seemed debatable. I've squashed it all into one commit now.

@jhadvig
Copy link
Member

jhadvig commented Feb 14, 2015

@rhcarvalho thanks. LGTM

@jhadvig
Copy link
Member

jhadvig commented Feb 14, 2015

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1059/)

@jhadvig
Copy link
Member

jhadvig commented Feb 16, 2015

[merge]

1 similar comment
@mfojtik
Copy link
Contributor

mfojtik commented Feb 16, 2015

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/921/) (Image: devenv-fedora_800)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 5f49d6e

openshift-bot pushed a commit that referenced this pull request Feb 16, 2015
@openshift-bot openshift-bot merged commit 7074988 into openshift:master Feb 16, 2015
@mfojtik
Copy link
Contributor

mfojtik commented Feb 16, 2015

@rhcarvalho thanks for doing this!

@mfojtik
Copy link
Contributor

mfojtik commented Feb 16, 2015

@rhcarvalho can you do the same for https://github.com/openshift/source-to-image ? ;-)

@rhcarvalho
Copy link
Contributor Author

@mfojtik 😋 yes

@rhcarvalho rhcarvalho deleted the typokiller branch April 29, 2015 10:05
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
* Add new Checksum field to BrokerStatus

This adds a check to run the broker reconciler if the spec has changed via
monitoring of the check sum field.

Closes openshift#1018

* Generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants