Conversation
b9c00da to
960d336
Compare
|
I also updated the cli to not show a Namespace column when rendering a Project, since a Project has no Namespace anymore. |
|
To "not"? ----- Original Message -----
|
|
To not, sorry. ----- Original Message ----- To "not"? ----- Original Message -----
Reply to this email directly or view it on GitHub: |
|
Sent note to mailing list notifying users of planned change. |
|
So the returned JSON for the virtual project resource will have displayName on an annotation instead of directly on the object correct? If so the UI code needs updating as well. |
|
The display name appears in Project.DisplayName like it did previously. It also appears in Project.Annotations["displayName"] in this PR as well. |
|
Are we deprecating it from being directly on displayName? |
|
No |
|
Don't use camel case, I'm not sure I can win that argument with brian. ----- Original Message -----
|
|
@smarterclayton - I forgot that battle was still ongoing, will update this PR. |
|
Remove the change to bindata.go, shouldn't be necessary |
960d336 to
6161b80
Compare
|
@jwforres - I removed the change to bindata.go, we need to figure out why its reporting as needed on my local machine longer term or standardize its build in a container. @smarterclayton - moved to use "displayname" as annotation. any other objections/concerns? |
|
Random travis flake in integration tests in unrelated area. |
There was a problem hiding this comment.
Another reason this has to be this way is that we have to run on kube directly - we should make a note somewhere that it's illegal to reference a kube registry from an openshift storage object.
|
Can you add an integration test for this? |
|
@smarterclayton - yes, will work on putting one together now. |
6161b80 to
ae85eae
Compare
|
@smarterclayton - added integration test to commit. |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/947/) (Image: devenv-fedora_819) |
|
Evaluated for origin up to ae85eae |
Merged by openshift-bot
Change the userspace proxy to wait for the node record
The PR introduces the following changes:
Namespace.Existence of a Project/Namespace prior to it's usage will be done in a separate PR.
There are some tweaks needed to upstream fake_namespaces.go in order to make better tests, but this still provides sufficient test coverage.
Enforcing creation of the
Projectprior to sticking content in its namespace will be done in a subsequent PR once the Admission Control stuff in Origin is settled./cc @smarterclayton @deads2k @jwforres