make useLocalImages the default and remove configurability#1063
make useLocalImages the default and remove configurability#1063openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
|
@smarterclayton review please. |
pkg/cmd/server/start.go
Outdated
There was a problem hiding this comment.
This doesn't have anything to do with the previous section, keep it separate.
|
We should make it explicit we're setting pullIfNotPresent. |
|
It's better to explicitly include it than rely on an upstream default. |
bparees
force-pushed
the
remove_local
branch
from
f273547 to
b40fccb
Compare
|
@smarterclayton done. |
|
LGTM, will merge after my change goes in. |
|
thank you for this!
|
|
Will merge once #1054 goes in |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/970/) (Image: devenv-fedora_840) |
|
Evaluated for origin up to b40fccb |
Merged by openshift-bot
4 participants
all containers for deployment/build will now just use the k8s default "pullIfNotPresent" behavior and there will be no way to override the behavior (the USE_LOCAL_IMAGES env variable is removed)