Try to wait for DinD to stop before exiting#107
Closed
ncdc wants to merge 1 commit intoopenshift:masterfrom
Closed
Try to wait for DinD to stop before exiting#107ncdc wants to merge 1 commit intoopenshift:masterfrom
ncdc wants to merge 1 commit intoopenshift:masterfrom
Conversation
Wait up to 10 seconds for the DinD daemon to stop before exiting from the build script. In my testing, allowing the daemon to stop fixes the dangling loopback device issue. Partial fix for openshift#101
Contributor
Author
Contributor
|
LGTM, can I get another signoff? |
Contributor
|
If #111 is accepted, this PR is obsolete. |
Contributor
|
Closing due to the decision to nuke the DinD for now due to non-support from upstream and potential resource leaks. |
pmorie
pushed a commit
to pmorie/origin
that referenced
this pull request
Nov 5, 2014
…vice Run gear daemon from /usr/bin so it can startup in local vagrant on boot
danwinship
pushed a commit
to danwinship/origin
that referenced
this pull request
Jun 24, 2016
multitenant cleanups; no actual bug fixes
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Feb 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait up to 10 seconds for the DinD daemon to stop before exiting from
the build script. In my testing, allowing the daemon to stop fixes the
dangling loopback device issue.
Partial fix for #101