Allow multiple tags to refer to the same image

[ncdc]

Modify ImageRepositoryMapping so it doesn't fail if the image specified
already exists.

Fixes #1154

[ncdc]

@bparees @smarterclayton PTAL

[ncdc]

[test]

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1184/)

[smarterclayton]

Create was not supposed to fail if it exists, however this is less surprising to users and the behavior is fine.

[ncdc]

@smarterclayton I'm not sure I understand what you mean.

[ncdc]

Are you saying we should modify image create so it doesn't fail if the image already exists?

[smarterclayton]

I'm saying that was the original intent, but it's fine if this code gets added. It reduces the difference between images and the rest of the system.

On Feb 26, 2015, at 6:37 AM, Andy Goldstein notifications@github.com wrote:

@smarterclayton I'm not sure I understand what you mean.

—
Reply to this email directly or view it on GitHub.

[ncdc]

Looks like I need to update an integration test too...

[ncdc]

[test]

[ncdc]

Not sure why Jenkins failed with this:

   --- FAIL: TestSimpleImageChangeBuildTrigger (0.09 seconds)
    deploy_trigger_test.go:317: Starting test openshift
    imagechange_buildtrigger_test.go:69: Expected build with base image registry:8080/openshift/test-image-trigger:ref-2, got registry:8080/openshift/test-image-trigger:ref-1

It works for me locally.

Let's try another [test]

[bparees]

Talk to michal and Maciej, they were looking into this failure. I think it's sporadic.

Ben Parees | OpenShift

-----Original Message-----
From: Andy Goldstein [notifications@github.com]
Received: Thursday, 26 Feb 2015, 12:39
To: openshift/origin [origin@noreply.github.com]
CC: Ben Parees [bparees@redhat.com]
Subject: Re: [origin] Allow multiple tags to refer to the same image (#1163)

Not sure why Jenkins failed with this:

   --- FAIL: TestSimpleImageChangeBuildTrigger (0.09 seconds)
    deploy_trigger_test.go:317: Starting test openshift
    imagechange_buildtrigger_test.go:69: Expected build with base image registry:8080/openshift/test-image-trigger:ref-2, got registry:8080/openshift/test-image-trigger:ref-1

It works for me locally.

Let's try another [test]

---

Reply to this email directly or view it on GitHub:
#1163 (comment)

[ncdc]

Alright, 2 clean jenkins runs. @bparees @smarterclayton let me know if this is ok or needs anything else

[bparees]

this fixes my problem so i'm going to [merge] it.

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1056/) (Image: devenv-fedora_916)

[openshift-bot]

Evaluated for origin up to a9c9d5f