Skip to content

fix nodelist defaulting#1182

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
deads2k:deads-fix-node-list
Mar 3, 2015
Merged

fix nodelist defaulting#1182
openshift-bot merged 1 commit intoopenshift:masterfrom
deads2k:deads-fix-node-list

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 27, 2015

Fixes #1161

When running an all-in-one, we always make sure that the --hostname parameter is included in the nodelist. When running an explicit master (openshift start master), we never touch the list.

@liggitt

liggitt
liggitt reviewed Feb 27, 2015
View reviewed changes
pkg/cmd/server/command.go Outdated
Copy link
Contributor

@liggitt liggitt Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build the set by iterating over the list, ToLower-ing, and ToLower hostname, to make sure --hostname=Localhost --nodes=localhost doesn't make you end up with localhost, localhost

Copy link
Contributor Author

@deads2k deads2k Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@deads2k deads2k force-pushed the deads-fix-node-list branch from c8712b1 to b1467e8 Compare February 27, 2015 17:24
liggitt
liggitt reviewed Feb 27, 2015
View reviewed changes
pkg/cmd/server/command.go
Copy link
Contributor

@liggitt liggitt Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logically, this can use cfg.StartMaster && cfg.StartNode as well... "if we're both a master and a node, make sure we know about ourselves". not sure the all-in-one-ness matters

@liggitt
Copy link
Contributor

liggitt commented Feb 27, 2015

LGTM

@deads2k deads2k force-pushed the deads-fix-node-list branch from b1467e8 to fe46756 Compare February 27, 2015 20:58
@deads2k
Copy link
Contributor Author

deads2k commented Feb 27, 2015

squashed [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2015

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1094/) (Image: devenv-fedora_955)

@deads2k
Copy link
Contributor Author

deads2k commented Feb 27, 2015

failed on TestRestrictedAccessForProjectAdmins with listing projects. Looks like the project authorization cache isn't being updated within two seconds on some of the jenkins machines.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 27, 2015

We need a better way to figure out when the project authorization cache is ready (or make it more responsive). For now, #1190 should help. re[merge]

@brenton brenton mentioned this pull request Feb 27, 2015
Closed
@liggitt
Copy link
Contributor

liggitt commented Feb 28, 2015

kicking stuck [merge] queue

@deads2k
Copy link
Contributor Author

deads2k commented Feb 28, 2015

Didn't have the asset server fix. re[merge]

@liggitt let's never touch that file again...

@deads2k
Copy link
Contributor Author

deads2k commented Feb 28, 2015

Something must be wrong with project listing (but not with policy or caching, the getters pass)

--- FAIL: TestRestrictedAccessForProjectAdmins (9.93 seconds)
    authorization_test.go:81: expected hammer-project, got []api.Project{}
    authorization_test.go:89: expected mallet-project, got []api.Project{}
FAIL

@derekwaynecarr I'm out on Monday, can you take a look? Welcome back.

@smarterclayton smarterclayton modified the milestone: 0.4.0 (beta2) Mar 2, 2015
@brenton
Copy link
Contributor

brenton commented Mar 3, 2015

@deads2k, any chance this will make it in today?

@deads2k
Copy link
Contributor Author

deads2k commented Mar 3, 2015

Talked @derekwaynecarr. I'll disable the list test for now with a TODO to get this through the merge queue.

@deads2k deads2k force-pushed the deads-fix-node-list branch from fe46756 to e2ff66a Compare March 3, 2015 16:35
@deads2k
Copy link
Contributor Author

deads2k commented Mar 3, 2015

re[merge]

@deads2k
Copy link
Contributor Author

deads2k commented Mar 3, 2015

build integration test transient: [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 3, 2015

Evaluated for origin up to e2ff66a

openshift-bot pushed a commit that referenced this pull request Mar 3, 2015
Merge pull request #1182 from deads2k/deads-fix-node-list
4c2c9f3 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 4c2c9f3 into openshift:master Mar 3, 2015
@deads2k deads2k deleted the deads-fix-node-list branch March 3, 2015 18:34
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Sep 14, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
c97184b 
…service-catalog/' changes from ef63307bdb..ae6b643caf

ae6b643caf Use oc adm instead of oadm which might not exist in various installations.
66a4eb2a2c Update instructions... will remove once documented elsewhere
1b704d1530 replace build context setup with init containers
ee4df18c7f hack/lib: dedup os::util::host_platform and os::build::host_platform
1cd6dfa998 origin: Switch out owners to Red Hatters
664f4d318f Add instructions for syncing repos
2f2cdd546b origin-build: delete files with colon in them
cdf8b12848 origin-build: don't build user-broker
ebfede9056 origin build: add _output to .gitignore
55412c7e3d origin build: make build-go and build-cross work
68c74ff4ae origin build: modify hard coded path
3d41a217f6 origin build: add origin tooling
a8fc27d Fix typos in walkthrough  (openshift#1224)
e77edbf openshift#1157: Limit the amount of time for reconciliations (openshift#1196)
1b1a749 temporarily disabled verify-links.sh from the verify target (openshift#1226)
acf8fab Send originating identity headers in OSB requests (openshift#1162)
821ba16 new admission controller to block updates to service instance updates that (openshift#1210)
d69c5e5 Minor improvement to godoc in binaries (openshift#1211)
5b81814 fix typos (openshift#1221)
836dc4a Adds how to download Helm chart (charts/catalog) (openshift#1219)
2fd0115 Fix "visit the project on github" link. (openshift#1217)
325e4b6 Add how to set $GOPATH. (openshift#1218)
68b775f Update the installation (openshift#1199)
6e3a3c1 v0.0.19 (openshift#1207)
8b69791 Removing errexit from TLS setup script (openshift#1206)
273260f Instance deletion lifecycle enhancements, issue openshift#820 (openshift#1159)
c050713 fix cleaning of build output for non-root users (openshift#1205)
5995df1 Merge branch 'pr/1204'
72f4802 Remove osb prefix from example ServiceClass (openshift#1201)
f9dbd4e pin all dependencies in glide to current version except for glog where we want to pick up the prior version to fix issue 1187.
f148bc5 v0.0.18 (openshift#1202)
b86ab8d Removing the helm install command (openshift#1185)
3cff482 Remove Alpha* prefix on all API fields for issue openshift#1180 (openshift#1184)
154b74d Fix gofmt issue (openshift#1192)
2ee894a do the clean before building an arch (openshift#1179)
b4976ef Fix bad URL (openshift#1189)
cd3dede Fix hrefs again (openshift#1190)
f066226 Design: Instance/Binding parameters (openshift#1075)
eb37682 This generated file is missing from master (openshift#1191)
28c0ae7 Use generation instead of checksum for Instances and InstanceCredentials (openshift#1151)
5cdd323 Fix bad href (openshift#1188)
8a892f0 handle lingering polling cases (openshift#1174)
f5fabd6 remove TPRs from Jenkins e2e pipeline (openshift#1175)
717df78 Add godoc explaining that Instance and InstanceCredential specs are immutable (openshift#1182)
REVERT: ef63307bdb origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: ae6b643cafd3a17412f173e70ed7c1a2e39ee549
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
@pmorie @kibbles-n-bytes
Add godoc explaining that Instance and InstanceCredential specs are i…
717df78 
…mmutable (openshift#1182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.0 (beta2)

Development

Successfully merging this pull request may close these issues.

openshift start master should not automatically create a node entry

5 participants

@deads2k @liggitt @openshift-bot @brenton @smarterclayton