Skip to content

Revert parallel Docker builds#12246

Closed
stevekuznetsov wants to merge 2 commits intoopenshift:masterfrom
stevekuznetsov:skuznets/revert-parallel-builds
Closed

Revert parallel Docker builds#12246
stevekuznetsov wants to merge 2 commits intoopenshift:masterfrom
stevekuznetsov:skuznets/revert-parallel-builds

Conversation

@stevekuznetsov
Copy link
Contributor

@stevekuznetsov stevekuznetsov commented Dec 13, 2016 •
edited
Loading

This reverts #12218 and #12229 to address #12236.

@deads2k PTAL

@stevekuznetsov
Revert "Merge pull request openshift#12229 from smarterclayton/build_…
d61563b 
…feedback"

This reverts commit f8b5dd6, reversing
changes made to a5ae7f1.
@stevekuznetsov
Revert "Merge pull request openshift#12218 from smarterclayton/handle…
6775123 
…_build"

This reverts commit b61cf87, reversing
changes made to e40d2bf.
@stevekuznetsov stevekuznetsov force-pushed the skuznets/revert-parallel-builds branch from 5cf722b to 6775123 Compare December 13, 2016 15:32
@deads2k
Copy link
Contributor

deads2k commented Dec 13, 2016

@smarterclayton @bparees the linked issue suggests reversion. I don't see a followup that fixes the problem. Any reason not to merge this?

[test]

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 13, 2016 •
edited
Loading

Generated with:

$ git revert f8b5dd6fe2b1e1e584e1f790435bcf9a98bf3eb3 -m 1
$ git revert b61cf87413a73268ff35fdeec0bade6b2e6eb61e -m 1

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 13, 2016

Evaluated for origin test up to 6775123

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 13, 2016

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12332/) (Base Commit: fb0bbde)

@deads2k
Copy link
Contributor

deads2k commented Dec 13, 2016

[merge]

@deads2k
Copy link
Contributor

deads2k commented Dec 13, 2016

@smarterclayton @bparees tagged for merge. If there's another fix, please link it when you remove the tag.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 13, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 6

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 13, 2016

Evaluated for origin merge up to 6775123

@smarterclayton
Copy link
Contributor

smarterclayton commented Dec 13, 2016

I merged yesterday.

@smarterclayton
Copy link
Contributor

smarterclayton commented Dec 13, 2016

#12229 was the revert of parallelism

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 13, 2016

Wow that's incredibly difficult to determine. Cool.

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 13, 2016

@smarterclayton we're seeing router-related issues like: #11644 (comment)

What's going on?

@smarterclayton
Copy link
Contributor

smarterclayton commented Dec 13, 2016 via email

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 13, 2016

Not entirely sure, I had some people ask me about the router flake this morning but it looks like they all happened late yesterday. If only we had some metrics ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@deads2k deads2k

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevekuznetsov @deads2k @openshift-bot @smarterclayton