fix missing serialization tag#1437
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Mar 25, 2015
Merged
Conversation
deads2k
force-pushed
the
deads-fix-missing-serialization
branch
from
aea5362 to
52712fb
Compare
Merged
deads2k
force-pushed
the
deads-fix-missing-serialization
branch
from
52712fb to
f124a7d
Compare
Contributor
Author
pkg/cmd/server/api/types.go
Outdated
Contributor
There was a problem hiding this comment.
don't mention keypairs... I don't think that's correct. "CertFile is a file containing a PEM-encoded certificate"
Contributor
|
LGTM otherwise |
deads2k
force-pushed
the
deads-fix-missing-serialization
branch
from
f124a7d to
b62263a
Compare
Contributor
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1296/) (Image: devenv-fedora_1132) |
Contributor
|
Evaluated for origin up to b62263a |
openshift-bot
pushed a commit
that referenced
this pull request
Mar 25, 2015
Merged by openshift-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@liggitt missing json tag and some godoc.