WIP: bundle-secret cmd#1518
Conversation
There was a problem hiding this comment.
the code should take any random directory, so fix up the comment and naming to just be 'dir'
There was a problem hiding this comment.
i prefer the use of flags instead of arguments.
openshift ex bundle-secret -f <myfolder> -option1 .. -option2 ...
Things to think about:
what is the api version format you will use when outputting the secret (v1beta1,2,3, etc.)
sallyom
force-pushed
the
bundle_secret
branch
3 times, most recently
from
7a40716 to
fd98a45
Compare
|
Will review and leave comments. Thanks! Sent from my iPhone
|
There was a problem hiding this comment.
bundle-secret NAME -f FILENAME
sallyom
force-pushed
the
bundle_secret
branch
7 times, most recently
from
a0a5ef6 to
36d88bf
Compare
There was a problem hiding this comment.
you don't need to base64 encode... []byte gets serialized as base64 by default... this will double encode
|
We need to make sure we can use shell expansion for selecting multiple files (can't require input files to be comma separated) if that means restructuring the args to make the source dirs/files the args, and the output file a switch, that might be reasonable |
There was a problem hiding this comment.
if you encounter an error, return it, don't do something that causes os.Exit() to happen down inside a command
sallyom
force-pushed
the
bundle_secret
branch
5 times, most recently
from
afb364c to
638b6d0
Compare
|
ok, ready for another round...looking forward to more feedback :) I'll check back later |
There was a problem hiding this comment.
Change to this:
err := readFile(item, secretData)
|
Made one request, but at this point, I would like to be able to make use of the function, and we can do any other necessary clean-up in a follow-on PR if needed. @liggitt agree? |
|
made the changes per feedback @derekwaynecarr |
|
follow up is fine with me |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1577/) (Image: devenv-fedora_1283) |
|
Evaluated for origin up to 3646760 |
Merged by openshift-bot
…service-catalog/' changes from 892b0368f0..3064247d05 3064247d05 origin build: add origin tooling 48ecff1 Chart changes for 0.1.2 (openshift#1527) 8727247 Fix change validator to look up serviceclass properly (openshift#1518) b0b138b Broker Reconciliation occurs too frequently (openshift#1514) cc816eb When a SI is unbindable, mark the binding request failed. (openshift#1522) 41290e9 Clarify semantics around RelistDuration (openshift#1516) 6bcb593 Send Context with UpdateInstanceRequest (openshift#1517) c3b72d8 Enforce stricly increasing broker relistRequests (openshift#1515) 01d81e5 Follow up from openshift#1450 and openshift#1444 (openshift#1504) 5e77882 Retry failed deprovision requests (openshift#1505) f6c891d Allow updates of instances that failed a previous update. (openshift#1502) 5107086 Use Plan ID from ExternalProperties when deprovisioning instance (openshift#1501) d897c60 Adding message builder for expected event strings (openshift#1465) 9f6152e update osb client and freeze gorilla context (openshift#1496) c63277e Add unit tests verifying deleting a resource with an on-going operation or in orphan mitigation. (openshift#1490) 4ecca16 Pretty logging for controller_instance.go (openshift#1472) c232db4 Register qemu statics when building non-amd64 images (openshift#1494) 0e54c57 fix 'Spring Cloud Services -> Configuring with Vault' link in docs (openshift#1495) REVERT: 892b0368f0 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 3064247d0544aa43f976d93caea0a11771434ef7
4 participants
No description provided.