registry: stop spamming logs with registry URL #15232
Conversation
| return nil, fmt.Errorf("%s variable must be set when running outside of Kubernetes cluster", DockerRegistryURLEnvVar) | ||
| } | ||
| } | ||
| context.GetLogger(ctx).Infof("Using %q as Docker Registry URL", registryAddr) |
There was a problem hiding this comment.
No, with debug level it will still spam logs on every request.
There was a problem hiding this comment.
Unless someone runs it with a less verbosive level. Why do we make the debug level default anyway? As the name suggests, it should be enabled when debugging.
IMHO this statement is useful - at least in case of debugging. Since there were reports about too verbosive output, I'd vote for making info the default log level instead of erasing useful statements completely.
openshift-merge-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfojtik No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfojtik No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfojtik No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfojtik No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
removed
the
approved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfojtik No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
openshift-merge-robot
added
approved
|
@mfojtik PR needs rebase |
openshift-merge-robot
added
the
needs-rebase
|
Superseded by #15796 |
6 participants
@miminar @dmage minor fix, I haven't realized this will spam every request...