Register SDN informers synchronously

[liggitt]

Pick of #15353 and more contained version of #15364

The SDN controller was registering shared informer event handlers in a goroutine, so registration raced with informer start. If the registration lost, then SDN event handlers would never get namespace events.

[openshift-bot]

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 14

[openshift-bot]

Evaluated for origin merge up to 07c92dd

[openshift-bot]

[Test]ing while waiting on the merge queue

[liggitt]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3303/) (Base Commit: 12575c5) (PR Branch Commit: 07c92dd)

[test]

[liggitt]

I'm seeing a consistent failure in the ansible install at the "Reconcile Cluster Roles and Cluster Role Bindings and Security Context Constraints." step:

Output to stderr: The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? The connection to the server ip-172-18-10-18.ec2.internal:8443 was refused - did you specify the right host or port? Error from server (Forbidden): User "system:admin" cannot get clusterroles at the cluster scope

[liggitt]

all-in-one master is dying with failed to start SDN plugin controller: User "system:serviceaccount:openshift-infra:sdn-controller" cannot get clusternetworks at the cluster scope

[liggitt]

looks like all the controller roles moved out of the block that auto-reconciles them on server start, which means ansible reconciliation races controllers which kill the process if they hit permission errors long enough

[openshift-bot]

Evaluated for origin test up to 04fdc79

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3338/) (Base Commit: 4c2392b) (PR Branch Commit: 04fdc79)

[liggitt]

@deads2k PTAL at the second commit for 3.6

[deads2k]

lgtm

[liggitt]

[merge]

[liggitt]

green tests on HEAD^, contains fix for flake other merge jobs are hitting, merging