Skip to content

[3.6] UPSTREAM: containers/image: <carry>: Do not check lifetime for v3 gpg signatures #15491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 27, 2017
Merged

[3.6] UPSTREAM: containers/image: <carry>: Do not check lifetime for v3 gpg signatures #15491

openshift-merge-robot merged 1 commit into from
Jul 27, 2017

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jul 27, 2017

3.6 version of #15490

@openshift-merge-robot openshift-merge-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 27, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Jul 27, 2017

@smarterclayton do we need release-3.6 branch PR's for things like this?

@mfojtik
Copy link
Contributor Author

mfojtik commented Jul 27, 2017

/retest-not-required

@mfojtik
Copy link
Contributor Author

mfojtik commented Jul 27, 2017 •
edited
Loading

/approve no-issue
/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 27, 2017

@mfojtik: you cannot LGTM your own PR.

Details

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xmichalis
Copy link
Contributor

0xmichalis commented Jul 27, 2017

/lgtm
/approve no-issue

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2017
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jul 27, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis, mfojtik

Associated issue requirement bypassed by: mfojtik

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jul 27, 2017

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 0e0901c into openshift:release-3.6 Jul 27, 2017
@mfojtik mfojtik deleted the 36-verify-image-fix branch September 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@smarterclayton smarterclayton

@0xmichalis 0xmichalis

@eparis eparis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/critical-fix retest-not-required size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mfojtik @openshift-ci-robot @0xmichalis @openshift-merge-robot @smarterclayton @eparis