Delete project should delete all project related resources#1601
Delete project should delete all project related resources#1601openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
8aac026 to
a6e4c38
Compare
|
It would have helped if my pushed branch included the unit testing changes. Summary of changes:
@smarterclayton @jwforres - this should be good to review now. this fixes the inability to delete a project in OpenShift right now ;-) |
a6e4c38 to
56b580f
Compare
|
@deads2k - if you have time, I just need someone to review ;-) |
There was a problem hiding this comment.
This seems slow. Does this mean that my namespace may not be cleaned up for a minute? During that minute, can I keep creating things?
There was a problem hiding this comment.
This means you will see a namespace appear in "Terminating" status for ~1 min. The value is the same default as upstream. You are unable to create content in a terminating namespace. There are two controllers that need to run in order to delete content (the k8s one, and the openshift one) so it will take ~1-2 minutes for something to truly be gone.
|
Minor comments. Otherwise, lgtm |
|
Assuming no other comments will look to merge in morning. Thanks for review David Sent from my iPhone
|
56b580f to
1b61bb3
Compare
|
after strategies move to |
3c41ee1 to
4c62345
Compare
|
changes made per request. will merge this now. |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1497/) (Image: devenv-fedora_1224) |
4c62345 to
cc1b809
Compare
|
re [merge] |
|
Evaluated for origin up to cc1b809 |
|
Which transient did you fail on? |
@smarterclayton @liggitt @jwforres - please take a quick look.
this builds off the cherry pick from:
#1570