use default handler #16178
Merged
use default handler #16178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
openshift-merge-robot
added
the
approved
deads2k
commented
Sep 6, 2017
| handler = apirequest.WithRequestContext(handler, genericConfig.RequestContextMapper) | ||
| handler = apiserverfilters.WithPanicRecovery(handler) | ||
| /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// | ||
| handler = apiserver.DefaultBuildHandlerChain(handler, genericConfig) |
Contributor
Author
There was a problem hiding this comment.
@sttts as a past rebaser, this should make you very happy.
deads2k
commented
Sep 6, 2017
|
|
||
| // we don't use this anymore | ||
| genericConfig.LegacyAuditWriter = nil | ||
| if masterConfig.AuditConfig.Enabled { |
deads2k
commented
Sep 6, 2017
| for k, v := range masterConfig.KubernetesMasterConfig.APIServerArguments { | ||
| args[k] = v | ||
| } | ||
| if masterConfig.AuditConfig.Enabled { |
openshift-merge-robot
added
the
needs-rebase
deads2k
force-pushed
the
server-42-use-default-handler
branch
from
b5369f1 to
0413dfb
Compare
openshift-merge-robot
added
needs-rebase
soltysh
approved these changes
Sep 7, 2017
| for k, v := range masterConfig.KubernetesMasterConfig.APIServerArguments { | ||
| args[k] = v | ||
| } | ||
| if masterConfig.AuditConfig.Enabled { |
| return nil, err | ||
| } | ||
|
|
||
| // we don't use this anymore |
Contributor
There was a problem hiding this comment.
I'll probably update this comment to explicitly mention we don't use legacy audit at all. All auditing in origin uses the new advanced feature.
|
|
||
| // we don't use this anymore | ||
| genericConfig.LegacyAuditWriter = nil | ||
| if masterConfig.AuditConfig.Enabled { |
Contributor
|
Rebase and ship it! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
deads2k
force-pushed
the
server-42-use-default-handler
branch
from
0413dfb to
06ef357
Compare
openshift-ci-robot
added
size/M
openshift-merge-robot
removed
the
needs-rebase
deads2k
force-pushed
the
server-42-use-default-handler
branch
from
06ef357 to
c16056e
Compare
deads2k
added
lgtm
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
Automatic merge from submit-queue (batch tested with PRs 14825, 15756, 16178, 16188, 16189) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on already lgtm'd pulls. Only the last commit is unique.
The biggest impact is to audit.
@soltysh @sttts you know want it before dcut today. :)