Add builds to status, also make status pluggable#1621
Add builds to status, also make status pluggable#1621openshift-bot merged 5 commits intoopenshift:masterfrom
Conversation
17444ab to
23f2782
Compare
|
Upstream pull is kubernetes/kubernetes#6493 |
23f2782 to
e19956d
Compare
|
instead of saying can you say that is the approach we took in the console alternatively... As it is currently the grammar is off.. |
|
The |
|
Is this supposed to indicate a build is in progress? Or is this like when you had it saying "deploying" and I had you change it to "deploys" |
|
The latter. ----- Original Message -----
|
|
It's really to indicate continuity (if the line was shorter it would all be on one line) ----- Original Message -----
|
|
We're using docker's human units, which does the "about a ". I'm fine with started running. ----- Original Message -----
|
|
other than that, the output lgtm. |
|
Comments addressed. ----- Original Message -----
|
f7daf4a to
c2c0de1
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1508/) (Image: devenv-fedora_1235) |
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1747/) |
d251772 to
ae95ccc
Compare
|
Evaluated for origin up to ae95ccc |
Adds builds and deployments to
osc status@jwforres review - to see sample output, uncomment the t.Logf at the bottom of projectstatus_test.go and run: