Skip to content

Add builds to status, also make status pluggable#1621

Merged
openshift-bot merged 5 commits intoopenshift:masterfrom
smarterclayton:improve_status
Apr 8, 2015
Merged

Add builds to status, also make status pluggable#1621
openshift-bot merged 5 commits intoopenshift:masterfrom
smarterclayton:improve_status

Conversation

@smarterclayton
Copy link
Contributor

Adds builds and deployments to osc status

@jwforres review - to see sample output, uncomment the t.Logf at the bottom of projectstatus_test.go and run:

hack/test-go.sh pkg/cmd/cli/describe -v -test.run=TestProjectStatus

@smarterclayton smarterclayton force-pushed the improve_status branch 2 times, most recently from 17444ab to 23f2782 Compare April 7, 2015 04:39
@smarterclayton
Copy link
Contributor Author

Upstream pull is kubernetes/kubernetes#6493

@jwforres
Copy link
Member

jwforres commented Apr 7, 2015

instead of saying

build 1 running about a minute ago

can you say

build 1 running for 1 minute

that is the approach we took in the console

alternatively...

build 1 started running about a minute ago

As it is currently the grammar is off..

@jwforres
Copy link
Member

jwforres commented Apr 7, 2015

The <- hanging on the end of the line feels strange

        service sinatra-app-example (172.30.17.47:8080 -> 8080)
          sinatra-app-example deploys sinatra-app-example:latest <-
            building git://github.com/mfojtik/sinatra-app-example with docker.io/openshift/ruby-20-centos7:latest

@jwforres
Copy link
Member

jwforres commented Apr 7, 2015

Is this supposed to indicate a build is in progress?

building git://github.com/mfojtik/sinatra-app-example with docker.io/openshift/ruby-20-centos7:latest

Or is this like when you had it saying "deploying" and I had you change it to "deploys"

@smarterclayton
Copy link
Contributor Author

The latter.

----- Original Message -----

Is this supposed to indicate a build is in progress?

building git://github.com/mfojtik/sinatra-app-example with
docker.io/openshift/ruby-20-centos7:latest

Or is this like when you had it saying "deploying" and I had you change it to
"deploys"


Reply to this email directly or view it on GitHub:
#1621 (comment)

@smarterclayton
Copy link
Contributor Author

It's really to indicate continuity (if the line was shorter it would all be on one line)

----- Original Message -----

The <- hanging on the end of the line feels strange

      service sinatra-app-example (172.30.17.47:8080 -> 8080)
        sinatra-app-example deploys sinatra-app-example:latest <-
          building git://github.com/mfojtik/sinatra-app-example with
          docker.io/openshift/ruby-20-centos7:latest

Reply to this email directly or view it on GitHub:
#1621 (comment)

@smarterclayton
Copy link
Contributor Author

We're using docker's human units, which does the "about a ". I'm fine with started running.

----- Original Message -----

instead of saying

build 1 running about a minute ago

can you say

build 1 running for 1 minute

that is the approach we took in the console

alternatively...

build 1 started running about a minute ago

As it is currently the grammar is off..


Reply to this email directly or view it on GitHub:
#1621 (comment)

@jwforres
Copy link
Member

jwforres commented Apr 7, 2015

other than that, the output lgtm.

@smarterclayton
Copy link
Contributor Author

Comments addressed.

----- Original Message -----

other than that, the output lgtm.


Reply to this email directly or view it on GitHub:
#1621 (comment)

@smarterclayton smarterclayton force-pushed the improve_status branch 3 times, most recently from f7daf4a to c2c0de1 Compare April 8, 2015 03:12
@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1508/) (Image: devenv-fedora_1235)

@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1747/)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to ae95ccc

openshift-bot pushed a commit that referenced this pull request Apr 8, 2015
@openshift-bot openshift-bot merged commit e6d024b into openshift:master Apr 8, 2015
@smarterclayton smarterclayton modified the milestone: 0.5.0 (beta3) Apr 23, 2015
@smarterclayton smarterclayton deleted the improve_status branch May 18, 2015 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants