Add `oc create imagestreamtag` #16224

smarterclayton · 2017-09-08T03:03:20Z

Supports all spec tag options. Specify a source with --from
(imagestreamtag) or --from-image (docker)

soltysh

I left you some comments.

soltysh · 2017-09-14T10:04:46Z

pkg/oc/cli/cmd/create/imagestreamtag.go

+	}
+
+	cmd.Flags().StringVar(&o.FromImage, "from-image", "", "Use the provided remote image with this tag.")
+	cmd.Flags().StringVar(&o.From, "from", "", "Use the provided image stream tag or image stream image as the source: [<namespace>/]name[:<tag>|@<id>]")


This is confusing to me and even more for users. We're currently using both for IS and docker image, see here and here not sure where else. We need to standardize on the naming and use it consistently everywhere.

Yeah, I think having source and from is worse than from and from-image and from-X. After all, that's consistent with oc create in general for oc create secrets which has from-file and from-literal.

I think in general source and from are first gen, while from and from-X are gen2

What I was hoping is that we unify this across all the places, so that user whenever see flag from or from-image or else knows what can expect. Either this can be solved as part of this PR or an issue, please.

But we can't break backwards compatibility, so it's more of a long running thing. I'd say a card is more appropriate, but we're not going to fix it anytime soon (i.e. i don't want to change tag or import-image right now, i'd want to ask "are we going to write an improved import-image that handles it")

I agree and I am aware of backwards compatibility :/ But at the same time it hurts our UX.

soltysh · 2017-09-14T10:06:05Z

pkg/oc/cli/cmd/create/imagestreamtag.go

+}
+
+func (o *CreateImageStreamTagOptions) Complete(cmd *cobra.Command, f *clientcmd.Factory, args []string) error {
+	o.DryRun = cmdutil.GetFlagBool(cmd, "dry-run")


👍 for the dry-run, we need it in more places :)

soltysh · 2017-09-14T10:10:21Z

test/cmd/images_tests.sh

+os::cmd::expect_success_and_text "oc get is/tag -o 'jsonpath={.spec.tags[?(@.name==\"7\")].referencePolicy}'" 'Local'
+os::cmd::expect_success_and_text "oc get is/tag -o 'jsonpath={.spec.tags[?(@.name==\"8\")].importPolicy.insecure}'" 'true'
+os::cmd::expect_success_and_text "oc get is/tag -o 'jsonpath={.spec.tags[?(@.name==\"9\")].importPolicy.scheduled}'" 'true'
+


I'm missing following tests:

Create tag with default tag name (latest) applied automatically (iow. oc create istag mytag) since I don't see any requirement on tag name being in the form repo:tag.

Create tag inside an existing IS, a oc create is + oc create istag sequence would be nice.

Negative tests (cli validation faliures, creating already existing tag, etc).

We don't do implicit latest here, adding a negative test. Will test inside.

smarterclayton · 2017-09-15T21:11:11Z

Removed the old image policy tests since we are +4 versions out.

Supports all spec tag options. Specify a source with --from (imagestreamtag) or --from-image (docker)

soltysh · 2017-09-18T12:07:24Z

/lgtm

openshift-merge-robot · 2017-09-18T12:07:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-merge-robot · 2017-09-18T12:07:33Z

/test all [submit-queue is verifying that this PR is safe to merge]

soltysh · 2017-09-18T13:17:37Z

Flake #16248
/retest

openshift-ci-robot · 2017-09-18T13:35:53Z

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/cmd	`860e49a`	link	`/test cmd`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2017-09-18T14:49:36Z

Automatic merge from submit-queue (batch tested with PRs 16224, 14227)

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2017

openshift-merge-robot assigned soltysh and liggitt Sep 8, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2017

smarterclayton added component/image sig/developer-experience and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 8, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2017

soltysh suggested changes Sep 14, 2017

View reviewed changes

smarterclayton force-pushed the createimagestreamtag branch 2 times, most recently from 03ea169 to 70967ff Compare September 15, 2017 21:10

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2017

Add oc create imagestreamtag

860e49a

Supports all spec tag options. Specify a source with --from (imagestreamtag) or --from-image (docker)

smarterclayton force-pushed the createimagestreamtag branch from 70967ff to 860e49a Compare September 16, 2017 01:01

soltysh approved these changes Sep 18, 2017

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2017

openshift-merge-robot merged commit f2946f6 into openshift:master Sep 18, 2017

Add oc create imagestreamtag #16224

Add oc create imagestreamtag #16224

Uh oh!

Conversation

smarterclayton commented Sep 8, 2017

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarterclayton commented Sep 15, 2017

Uh oh!

soltysh commented Sep 18, 2017

Uh oh!

openshift-merge-robot commented Sep 18, 2017

Uh oh!

openshift-merge-robot commented Sep 18, 2017

Uh oh!

soltysh commented Sep 18, 2017

Uh oh!

openshift-ci-robot commented Sep 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-robot commented Sep 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add `oc create imagestreamtag` #16224

Add `oc create imagestreamtag` #16224

openshift-ci-robot commented Sep 18, 2017 •

edited

Loading