Skip to content

Conversation

@pospispa
Copy link

Automatic detection of Cinder API version doesn't work.
The problem is described in Bugzilla #14907688 (https://bugzilla.redhat.com/show_bug.cgi?id=1490768).

The problem is in the gophercloud library that doesn't support HTTP code 300 in pagination.
This problem is fixed in PR: gophercloud/gophercloud#383

That's why the gophercloud library version is bumped up to ed590d9afe113c6107cd60717b196155e6579e78

fix https://bugzilla.redhat.com/show_bug.cgi?id=1490768

@rootfs PTAL

…96155e6579e78

Automatic detection of Cinder API version doesn't work.
The problem is described in Bugzilla #14907688 (https://bugzilla.redhat.com/show_bug.cgi?id=1490768).

The problem is in the gophercloud library that doesn't support HTTP code 300 in pagination.
This problem is fixed in PR: gophercloud/gophercloud#383

That's why the gophercloud library version is bumped up to ed590d9afe113c6107cd60717b196155e6579e78
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2017
@pospispa
Copy link
Author

flake #16248

@pospispa
Copy link
Author

/test cmd

@bparees
Copy link
Contributor

bparees commented Sep 13, 2017

/unassign

@pospispa
Copy link
Author

/test integration

@rootfs
Copy link
Member

rootfs commented Sep 13, 2017

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2017
@rootfs
Copy link
Member

rootfs commented Sep 13, 2017

/assign @mfojtik

@pospispa
Copy link
Author

/test integration

@soltysh
Copy link
Contributor

soltysh commented Sep 14, 2017

/unassign

@eparis
Copy link
Member

eparis commented Sep 14, 2017

/approve
/hold
Is this the version used upstream in kube??

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, pospispa, rootfs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2017
@pospispa
Copy link
Author

@eparis K8s 1.7 release branch uses this version, i.e. ed590d9afe113c6107cd60717b196155e6579e78
However, both K8s 1.8 release branch and K8s master use a newer version of gophercloud library: 2bf16b94fdd9b01557c4d076e567fe5cbbe5a961

@childsb
Copy link
Contributor

childsb commented Sep 15, 2017

Any objections to merging @eparis ?

@eparis
Copy link
Member

eparis commented Sep 15, 2017

no, clear the hold on monday.

@eparis
Copy link
Member

eparis commented Sep 18, 2017

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15834, 16321, 16353, 15298, 15433)

@openshift-merge-robot openshift-merge-robot merged commit 9cd1dc3 into openshift:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants