Skip to content

Add ability to select integration tests and change log level #16345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmage wants to merge 1 commit into from
Closed

Add ability to select integration tests and change log level #16345

dmage wants to merge 1 commit into from

Conversation

@dmage
Copy link
Contributor

@dmage dmage commented Sep 14, 2017

Usage example:

LOGLEVEL=5 ./hack/test-integration.sh -run TestIntegration/TestImageStreamImportDockerHub -v

Add ability to select integration tests and change log level
5386ec5 
Usage example:

    LOGLEVEL=5 ./hack/test-integration.sh -run TestIntegration/TestImageStreamImportDockerHub -v
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Sep 14, 2017

\o/

@stevekuznetsov any objections?

@mfojtik
Copy link
Contributor

mfojtik commented Sep 14, 2017

/approve

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Sep 14, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, mfojtik

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2017 •
edited
Loading

@dmage: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration 5386ec5 link /test integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Sep 14, 2017

Please accompany this with an update to HACKING.md

/cc @enj

@enj
Copy link
Contributor

enj commented Sep 14, 2017

Added do not merge, this is incorrect, will update later when I have time.

@enj
Copy link
Contributor

enj commented Sep 14, 2017

xref #16153

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Sep 14, 2017

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2017
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Sep 14, 2017

@enj we have a process, gosh darn it

@dmage
Copy link
Contributor Author

dmage commented Sep 16, 2017

Ok, lets focus our efforts in that PR. I have two bugs there: GOTESTFLAGS is ignored, the verbosity level is always set to the maximum value.

@dmage dmage closed this Sep 16, 2017
dmage
dmage commented Sep 16, 2017
View reviewed changes
test/integration/runner/runner_test.go
cmd.Args = append(cmd.Args, "-test.short")
}
cmd.Args = append(cmd.Args, "-test.timeout", (*timeout).String())
cmd.Args = append(cmd.Args, "-v", fmt.Sprintf("%d", loglevel))
Copy link
Contributor Author

@dmage dmage Sep 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUG: loglevel -> *loglevel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enj enj Awaiting requested review from enj

Assignees

@danwinship danwinship

@marun marun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dmage @mfojtik @openshift-merge-robot @openshift-ci-robot @stevekuznetsov @enj @danwinship @marun