Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 15, 2017

Use a specific, private scheme to handle the conversion of internal image apis stuff.

@bparees @soltysh found it!

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2017
@bparees
Copy link
Contributor

bparees commented Sep 15, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, deads2k

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2017
@deads2k deads2k force-pushed the image-06-conversion branch from c8adfb4 to 29b3f64 Compare September 18, 2017 12:38
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 18, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Sep 18, 2017

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Sep 18, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Sep 18, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16226, 16377, 15766, 16299, 16153)

@openshift-merge-robot openshift-merge-robot merged commit 8452500 into openshift:master Sep 18, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2017

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 29b3f64 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce 29b3f64 link /test extended_conformance_gce
ci/openshift-jenkins/extended_networking_minimal 29b3f64 link /test extended_networking_minimal
ci/openshift-jenkins/cmd 29b3f64 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k deleted the image-06-conversion branch January 24, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants