Skip to content

Router - hsts for "edge" or "reencrypt" only#16888

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
pecameron:bz1501133
Oct 18, 2017
Merged

Router - hsts for "edge" or "reencrypt" only#16888
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
pecameron:bz1501133

Conversation

@pecameron
Copy link
Contributor

@pecameron pecameron commented Oct 16, 2017

Suppress Strict-Transport-Security header for http requests
It is only emitted for https.

bug 1501133
https://bugzilla.redhat.com/show_bug.cgi?id=1501133
see comment #3

@pecameron
Router - hsts for "edge" or "reencrypt" only
c8a9af0 
Suppress Strict-Transport-Security header for http requests
It is only emitted for https.

bug 1501133
https://bugzilla.redhat.com/show_bug.cgi?id=1501133
see comment openshift#3
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2017
@pecameron
Copy link
Contributor Author

pecameron commented Oct 16, 2017

@knobunc PTAL

knobunc
knobunc reviewed Oct 17, 2017
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 17, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, pecameron

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2017
@knobunc
Copy link
Contributor

knobunc commented Oct 17, 2017 •
edited
Loading

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 17, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 18, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2017 •
edited
Loading

@pecameron: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/verify c8a9af0 link /test verify
ci/openshift-jenkins/cmd c8a9af0 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 18, 2017

Automatic merge from submit-queue (batch tested with PRs 16888, 16911, 16913, 16904).

@openshift-merge-robot openshift-merge-robot merged commit 91ca5a4 into openshift:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc knobunc left review comments

Assignees

@tdawson tdawson

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pecameron @openshift-merge-robot @knobunc @openshift-bot @openshift-ci-robot @tdawson