Skip to content

add db sample templates#1776

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
bparees:db_templates
Apr 17, 2015
Merged

add db sample templates#1776
openshift-bot merged 1 commit intoopenshift:masterfrom
bparees:db_templates

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Apr 16, 2015

No description provided.

@bparees
Copy link
Contributor Author

bparees commented Apr 16, 2015

@danmcp ptal.
@sspeiche @mfojtik @ewolinetz fyi, these are likely relevant to the app demo work you're doing... all I did to validate them was instantiate them, so if you guys could actually try them out (ie make sure the DBs are usable/connectable) that'd be nice too.

@danmcp
Copy link

danmcp commented Apr 16, 2015

@bparees Where do we put the rhel ones?

@bparees bparees changed the title add db sample templates [DO_NOT_MERGE] add db sample templates Apr 16, 2015
@bparees bparees changed the title [DO_NOT_MERGE] add db sample templates add db sample templates Apr 16, 2015
@bparees bparees force-pushed the db_templates branch 2 times, most recently from de4ac03 to db81369 Compare April 16, 2015 20:28
@bparees
Copy link
Contributor Author

bparees commented Apr 16, 2015

@danmcp ok, rhel7 support added. note that the services created by these templates do NOT have the OS name in them, so you still can't create both templates in the same project. Having the OS name in the service seemed annoying from the perspective of an app that might want to start out using the centos version of the DB images and then switch to rhel later.

also I got the beta channel registry name and used it, but i have no way to validate that right now, so someone ought to try those out.

@danmcp
Copy link

danmcp commented Apr 16, 2015

LGTM [merge]

@mfojtik
Copy link
Contributor

mfojtik commented Apr 16, 2015

@bparees I assume that scaling/replica is out of scope here and require
another set if templating. correct?
On Apr 16, 2015 10:45 PM, "OpenShift Bot" notifications@github.com wrote:

Evaluated for origin up to db81369
db81369

—
Reply to this email directly or view it on GitHub
#1776 (comment).

@bparees
Copy link
Contributor Author

bparees commented Apr 16, 2015

@mfojtik yeah, this is the dead simple case. I did debate stealing your replica template json for the mongo template but decided against it.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2015

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1603/) (Image: devenv-fedora_1294)

@bparees
Copy link
Contributor Author

bparees commented Apr 17, 2015

[merge]

@bparees
Copy link
Contributor Author

bparees commented Apr 17, 2015

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2015

Evaluated for origin up to d5bf141

openshift-bot pushed a commit that referenced this pull request Apr 17, 2015
Merge pull request #1776 from bparees/db_templates
f6af944 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit f6af944 into openshift:master Apr 17, 2015
@bparees bparees deleted the db_templates branch April 21, 2015 17:13
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Mar 1, 2018
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
f72ed83 
…service-catalog/' changes from b758460ba7..c3e3071633

c3e3071633 origin build: add origin tooling
97ddbab chart changes for v0.1.9 (openshift#1776)
b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763)
97d11cb prometheus: only return catalog specific metrics (openshift#1774)
0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775)
0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770)
28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768)
ca83d18 handle binding deletion that occurs during async bind (openshift#1760)
858d467 2 of 4 fixes for golang 1.10 (openshift#1764)
656156b Add unit tests for binding and broker backends in svcat
ec05486 In svcat verify service instance exists on unbind (openshift#1750)
e6315a4 fix indentation from openshift#1725 (openshift#1759)
62284da Publish svcat binaries during build (openshift#1725)
8f986ae also build with golang tip and allow tip to fail (openshift#1734)
127561e use pvc for etcd volume (openshift#1684)
7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693)
4ea44c4 log the version and build date on server startup (openshift#1746)
0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743)
b1da783 print schemas when describing plan in svcat (openshift#1740)
7a7fcce Add constraint for go-open-service-broker-client (openshift#1738)
3070003 Increase timeout for broker condition polling in e2e (openshift#1745)
b6878f7 Avoid Setting Authentication header twice (openshift#1685)
5317111 wrap "rm -rf" with docker (openshift#1735)
d7c0bf2 Allow upper case letters in Plan names (openshift#1668)
6b27ba6  Add a constraint on go-autorest  (openshift#1732)
b3de6ec Added validation for ServiceBinding spec ParametersFrom
REVERT: b758460ba7 origin build: modify hard coded path
REVERT: 871582f73a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Mar 1, 2018
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
f574d6f 
…service-catalog/' changes from b758460ba7..c3e3071633

c3e3071633 origin build: add origin tooling
97ddbab chart changes for v0.1.9 (openshift#1776)
b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763)
97d11cb prometheus: only return catalog specific metrics (openshift#1774)
0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775)
0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770)
28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768)
ca83d18 handle binding deletion that occurs during async bind (openshift#1760)
858d467 2 of 4 fixes for golang 1.10 (openshift#1764)
656156b Add unit tests for binding and broker backends in svcat
ec05486 In svcat verify service instance exists on unbind (openshift#1750)
e6315a4 fix indentation from openshift#1725 (openshift#1759)
62284da Publish svcat binaries during build (openshift#1725)
8f986ae also build with golang tip and allow tip to fail (openshift#1734)
127561e use pvc for etcd volume (openshift#1684)
7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693)
4ea44c4 log the version and build date on server startup (openshift#1746)
0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743)
b1da783 print schemas when describing plan in svcat (openshift#1740)
7a7fcce Add constraint for go-open-service-broker-client (openshift#1738)
3070003 Increase timeout for broker condition polling in e2e (openshift#1745)
b6878f7 Avoid Setting Authentication header twice (openshift#1685)
5317111 wrap "rm -rf" with docker (openshift#1735)
d7c0bf2 Allow upper case letters in Plan names (openshift#1668)
6b27ba6  Add a constraint on go-autorest  (openshift#1732)
b3de6ec Added validation for ServiceBinding spec ParametersFrom
REVERT: b758460ba7 origin build: modify hard coded path
REVERT: 871582f73a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Mar 8, 2018
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
fc02f43 
…service-catalog/' changes from b758460ba7..c3e3071633

c3e3071633 origin build: add origin tooling
97ddbab chart changes for v0.1.9 (openshift#1776)
b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763)
97d11cb prometheus: only return catalog specific metrics (openshift#1774)
0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775)
0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770)
28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768)
ca83d18 handle binding deletion that occurs during async bind (openshift#1760)
858d467 2 of 4 fixes for golang 1.10 (openshift#1764)
656156b Add unit tests for binding and broker backends in svcat
ec05486 In svcat verify service instance exists on unbind (openshift#1750)
e6315a4 fix indentation from openshift#1725 (openshift#1759)
62284da Publish svcat binaries during build (openshift#1725)
8f986ae also build with golang tip and allow tip to fail (openshift#1734)
127561e use pvc for etcd volume (openshift#1684)
7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693)
4ea44c4 log the version and build date on server startup (openshift#1746)
0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743)
b1da783 print schemas when describing plan in svcat (openshift#1740)
7a7fcce Add constraint for go-open-service-broker-client (openshift#1738)
3070003 Increase timeout for broker condition polling in e2e (openshift#1745)
b6878f7 Avoid Setting Authentication header twice (openshift#1685)
5317111 wrap "rm -rf" with docker (openshift#1735)
d7c0bf2 Allow upper case letters in Plan names (openshift#1668)
6b27ba6  Add a constraint on go-autorest  (openshift#1732)
b3de6ec Added validation for ServiceBinding spec ParametersFrom
REVERT: b758460ba7 origin build: modify hard coded path
REVERT: 871582f73a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bparees @danmcp @mfojtik @openshift-bot