UPSTREAM:17757 unit test k8s.io/kubernetes/pkg/kubelet/rkt TestVersion

[RobertKrawitz]

Two issues:

Main issue is that fakeRuntime.Start() is returning prior to the listener being set up, and the remote runtime test is assuming that everything is ready. Whether this happens correctly or not depends upon factors such as speed of and load on the system under test among others. Solution: fakeRuntime.Start() must not return until it has successfully created the listener. remote.createAndStartFakeRemoteRuntime() must call fakeremote.Start() normally, and fakeRemote.Start() must call RemoteRuntime.server.Serve() as a goroutine.

Secondary issue (causing a segv rather than a more useful error message) is that various places in remote_runtime_test.go must require.noError() rather than assert.noError().

Tested by introducing a 1 second sleep in util.createListener, test failed every time. Fix #1, problem did not reproduce in about 10 tries. Also ran a long loop, and adding load to the system. No failures after 16726 iterations.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobertKrawitz
We suggest the following additional approver: derekwaynecarr

Assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• vendor/k8s.io/kubernetes/pkg/kubelet/OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[DirectXMan12]

This needs to be filed against Kubernetes first, if it's not already fixed there, and then backported (or pulled in via a rebase) once it merges.

[openshift-ci-robot]

@RobertKrawitz: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install	9b12017	link	/test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.