Skip to content

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Feb 2, 2018

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 2, 2018
@jsafrane
Copy link
Contributor

jsafrane commented Feb 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2018
@childsb
Copy link
Contributor

childsb commented Feb 5, 2018

/approve

@gnufied
Copy link
Member Author

gnufied commented Feb 5, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2018
@gnufied gnufied force-pushed the fix-mounted-volume-resize branch from 233c14f to 711bdc8 Compare February 7, 2018 03:28
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@gnufied
Copy link
Member Author

gnufied commented Feb 7, 2018

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2018
@gnufied
Copy link
Member Author

gnufied commented Feb 7, 2018

@jsafrane @childsb I just rebased this with master again. Need another round of approvals, thank you.

@jsafrane
Copy link
Contributor

jsafrane commented Feb 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@childsb
Copy link
Contributor

childsb commented Feb 7, 2018

/approve

@gnufied
Copy link
Member Author

gnufied commented Feb 8, 2018

/assign @smarterclayton

@jsafrane
Copy link
Contributor

jsafrane commented Feb 9, 2018

/assign @mfojtik
for approval

@mfojtik
Copy link
Contributor

mfojtik commented Feb 12, 2018

/approve no-issue

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, gnufied, jsafrane, mfojtik

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2018
@jsafrane
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 30d9a60 into openshift:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants