Picks for volume manager #18636
Merged
Picks for volume manager #18636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-merge-robot
added
the
vendor-update
Contributor
|
/lgtm |
Contributor
|
Flake: #18626. But why in Projected test? I hope we don't have new flake. |
Contributor
|
/retest |
Contributor
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mfojtik, sjenning The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Contributor
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @jsafrane for these fixes
kubernetes/kubernetes#59873
kubernetes/kubernetes#59923
59923 modified from upstream because some logging levels where already higher in 1.9
xref https://bugzilla.redhat.com/show_bug.cgi?id=1538216
Fixes #17605
Fixes #17556
@derekwaynecarr