UPSTREAM: cobra loses arguments with same value as subcommand#1901
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Apr 24, 2015
Merged
Conversation
Member
|
Seems a duplicate: #1447 |
Contributor
Author
Mine has a patch :) |
Member
|
LGTM. Could add a test. |
Member
|
Actually the test should be upstream. |
Contributor
Author
|
will add the test upstream. [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1669/) (Image: devenv-fedora_1355) |
Contributor
|
Evaluated for origin up to 1dad834 |
openshift-bot
pushed a commit
that referenced
this pull request
Apr 24, 2015
Merged by openshift-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1894
Fixes: #1447
Upstream: spf13/cobra#95
running a command like:
where
adminandmy-userare arguments to theopenshift admin policy add-role-to-usercommand, removes theadminargument (args[4]).This pull stops removing more than one token from the
argsfor command matches.@fabianofranz ptal