Skip to content

UPSTREAM: 54300: Fix test images#19292

Closed
jsafrane wants to merge 1 commit intoopenshift:masterfrom
jsafrane:fix-iscsi-image-name
Closed

UPSTREAM: 54300: Fix test images#19292
jsafrane wants to merge 1 commit intoopenshift:masterfrom
jsafrane:fix-iscsi-image-name

Conversation

@jsafrane
Copy link
Contributor

  • fix lot of storage tests.

This fixes one of test failures reported in #19260

+ fix lot of storage tests.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: soltysh

Assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot requested review from enj and sttts April 10, 2018 10:37
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2018

@jsafrane: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 78d9eb5 link /test extended_conformance_install
ci/openshift-jenkins/gcp 78d9eb5 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor Author

Tested locally with

FOCUS="Volumes.*SCSI.*" test/extended/core.sh

It passes, however I had to install iscsiadm on my nodes. I commented that in #19260 - perhaps iscsi should be excluded.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2018
@openshift-bot
Copy link
Contributor

@jsafrane: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor Author

Not necessary after rebase.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants