Cleanup sysconfig values as everything is now in a config file#1935
Cleanup sysconfig values as everything is now in a config file#1935openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
sdodson
force-pushed
the
only-use-nodeconfig
branch
from
8553a6b to
410cd43
Compare
* Cleanup several unused items now that everything is stored in config
files, now the only things in our sysconfig files are the paths to
the openshift config files and OPTIONS
* Create /etc/openshift/{master,node} in their respective packages
sdodson
force-pushed
the
only-use-nodeconfig
branch
from
410cd43 to
b5ffc45
Compare
There was a problem hiding this comment.
I'm not certain what to do about this, if they have a config file as the services expect them to then passing this as a commandline argument is ignored, but then we have no way other than generating a config file to set the default registry.
If we care, perhaps this could be adjusted to patch pkg/cmd/util/variable/imagetemplate.go or override it at build time with an ldflag somehow?
There was a problem hiding this comment.
With the other changes, the services will choke without a config file anyway. I guess I don't really see a problem with that, although maybe we should supply config files with some workable defaults so that the services will start out of the box? Given we expect to be using the ansible installer, and the rate of change of config, not sure we want that yet though.
I guess LGTM as-is.
There was a problem hiding this comment.
Thanks, sounds good to me.
|
@sosiouxme Mind taking a look at this? It's re-incarnation of #1616 which we tried to merge but kept hitting flakiness and it then ran into merge conflicts and was ultimately closed. |
|
How about we [merge] then while we can... |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1729/) (Image: devenv-fedora_1397) |
|
Evaluated for origin up to b5ffc45 |
Merged by openshift-bot
3 participants
files, now the only things in our sysconfig files are the paths to
the openshift config files and items that should be specified as OPTIONS and cannot be defined in
the config file.