Require Go 1.4 for OpenShift#2006
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom May 19, 2015
Merged
Conversation
Contributor
Author
|
Covers #1070 |
hack/verify-gofmt.sh
Outdated
Contributor
There was a problem hiding this comment.
If we're going to require 1.4, why keep 1.2 & 1.3 here?
Member
|
Mind bumping the rpm build requires in the same PR? |
smarterclayton
force-pushed
the
require_go_14
branch
from
2b93ede to
f457459
Compare
Member
|
Should be fine to merge this WRT to RHEL builds. I don't know for certain that golang-1.4 is available for Centos yet. |
Contributor
Author
|
I don't believe it is, yet. |
Contributor
|
@smarterclayton it is. |
smarterclayton
force-pushed
the
require_go_14
branch
from
f457459 to
1728638
Compare
Contributor
Author
|
[test] |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2254/) |
smarterclayton
changed the title
Contributor
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2254/) (Image: devenv-fedora_1564) |
Contributor
|
Evaluated for origin up to 1728638 |
openshift-bot
pushed a commit
that referenced
this pull request
May 19, 2015
Merged by openshift-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannot be merged until centos7 has Go 1.4 available as RPMs.