Skip to content

Apply defaults to bootstrap SCCs before reconciliation#20197

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
liggitt:round-trip-default-sccs
Jul 4, 2018
Merged

Apply defaults to bootstrap SCCs before reconciliation#20197
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
liggitt:round-trip-default-sccs

Conversation

@liggitt
Copy link
Contributor

@liggitt liggitt commented Jul 3, 2018

#20152 added a new field to SCC objects, which defaults to true if unspecified. The in-memory bootstrap SCC objects weren't updated to populate this field, which meant that when they were compared to objects from the server, it appeared there were differences that required them to be updated.

This round-trips the bootstrap SCC objects to make sure all the same defaults are applied to them.

Fixes spurious reconcile-scc output for defaulted fields

/assign @simo5
/cc @sdodson @michaelgugino

@openshift-ci-robot
Copy link

@liggitt: GitHub didn't allow me to assign the following users: simo.

Note that only openshift members and repo collaborators can be assigned.

Details

In response to this:

Fixes spurious reconcile-scc output for defaulted fields

/assign @Simo
/cc @sdodson @michaelgugino

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2018
@simo5
Copy link
Contributor

simo5 commented Jul 3, 2018

/assign @stlaz
cc @openshift/sig-security

@enj
Copy link
Contributor

enj commented Jul 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Contributor Author

liggitt commented Jul 3, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 33cffaf into openshift:master Jul 4, 2018
@liggitt liggitt deleted the round-trip-default-sccs branch July 11, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/security size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants