Apply defaults to bootstrap SCCs before reconciliation#20197
Apply defaults to bootstrap SCCs before reconciliation#20197openshift-merge-robot merged 1 commit intoopenshift:masterfrom liggitt:round-trip-default-sccs
Conversation
|
@liggitt: GitHub didn't allow me to assign the following users: simo. Note that only openshift members and repo collaborators can be assigned. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @stlaz |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
#20152 added a new field to SCC objects, which defaults to
trueif unspecified. The in-memory bootstrap SCC objects weren't updated to populate this field, which meant that when they were compared to objects from the server, it appeared there were differences that required them to be updated.This round-trips the bootstrap SCC objects to make sure all the same defaults are applied to them.
Fixes spurious
reconcile-sccoutput for defaulted fields/assign @simo5
/cc @sdodson @michaelgugino