externalize remaining adm commands#20972
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Sep 17, 2018
Merged
externalize remaining adm commands#20972openshift-merge-robot merged 3 commits intoopenshift:masterfrom
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
juanvallejo
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/test end_to_end |
soltysh
approved these changes
Sep 13, 2018
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
One nit, and well tests. Feel free to self-lgtm it.
/approve
| userclient "github.com/openshift/origin/pkg/user/generated/internalclientset" | ||
| userv1 "github.com/openshift/api/user/v1" | ||
| userv1typedclient "github.com/openshift/client-go/user/clientset/versioned/typed/user/v1" | ||
| kerrors "k8s.io/apimachinery/pkg/api/errors" |
openshift-ci-robot
added
the
approved
juanvallejo
force-pushed
the
jvallejo/externalize-remaining-adm-commands
branch
from
fc38e24 to
c8789c2
Compare
openshift-ci-robot
added
size/L
juanvallejo
force-pushed
the
jvallejo/externalize-remaining-adm-commands
branch
from
c8789c2 to
7aa34fb
Compare
openshift-ci-robot
removed
lgtm
Contributor
Author
|
/retest |
Contributor
Author
|
@soltysh thanks, review comments addressed. Needs to be re-approved once more (updated integration test) |
soltysh
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: juanvallejo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the following admin commands to externals:
cert(these appear to live in the server, and do not need to be updated)Updates the following non-admin commands to externals:
cc @soltysh