Remove autogenerated docs folder and gitserver by smarterclayton · Pull Request #20981 · openshift/origin

smarterclayton · 2018-09-14T03:49:53Z

Removed gitserver (someone can move it out if they want later)
Removed checked in docs files
Docs aren't generated for the openshift binary anymore, because we won't build RPMs for it and so it won't be visible to anyone in 4.0. Operators also control this.

bparees · 2018-09-14T03:52:48Z

we use the gitserver in our extended tests to test private repositories.

smarterclayton · 2018-09-14T04:16:58Z

We do, but we can continue using the previous tag.

On Fri, Sep 14, 2018 at 12:05 AM OpenShift CI Robot < ***@***.***> wrote: @smarterclayton <https://github.com/smarterclayton>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/extended_clusterup f89a5e0 <f89a5e0> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20981/test_pull_request_origin_extended_clusterup/5268/> /test extended_clusterup ci/openshift-jenkins/end_to_end f89a5e0 <f89a5e0> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20981/test_pull_request_origin_end_to_end/17120/> /test end_to_end ci/openshift-jenkins/extended_conformance_install f89a5e0 <f89a5e0> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20981/test_pull_request_origin_extended_conformance_install/15529/> /test extended_conformance_install Full PR test history <https://openshift-gce-devel.appspot.com/pr/20981>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/smarterclayton>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20981 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p48QxHoK9Fsj7nhEqMKAhlp3s_Jvks5uaysCgaJpZM4WokmU> .

soltysh

/lgtm

soltysh · 2018-09-14T10:25:44Z

tools/genman/gen_man.go

 func main() {
 	if len(os.Args) < 3 {
-		fmt.Fprintf(os.Stderr, "Root command not specified (oc | openshift).\n")
+		fmt.Fprintf(os.Stderr, "Root command not specified (oc).\n")


If we're not generating man pages at all, do we care about the tool at all?

we are generating man pages for oc still

But we're not checking it in, right?

openshift-ci-robot · 2018-09-14T10:28:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2018-09-14T11:04:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-09-14T13:05:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-09-14T15:06:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2018-09-14T15:24:44Z

New changes are detected. LGTM label has been removed.

openshift-ci-robot · 2018-09-14T16:45:04Z

New changes are detected. LGTM label has been removed.

smarterclayton · 2018-09-14T20:15:55Z

/retest

smarterclayton · 2018-09-14T22:07:34Z

/retest

smarterclayton · 2018-09-14T23:53:49Z

/retest

openshift-ci-robot · 2018-09-14T23:55:14Z

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/gcp	`a1aa53a`	link	`/test gcp`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

smarterclayton · 2018-09-14T23:55:29Z

Multiple flakes, merging to avoid rebase conflicts

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2018

openshift-ci-robot requested review from bparees and csrwng September 14, 2018 03:50

smarterclayton force-pushed the cleanup_leftovers branch from f89a5e0 to 33b9c13 Compare September 14, 2018 05:31

openshift-ci-robot assigned soltysh Sep 14, 2018

soltysh approved these changes Sep 14, 2018

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2018

smarterclayton force-pushed the cleanup_leftovers branch from 33b9c13 to d5c1cb3 Compare September 14, 2018 15:24

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2018

smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2018

smarterclayton added 3 commits September 14, 2018 12:44

Remove checked in docs and empty man directories

6f5a61b

Prevent new contents from being checked in to docs dir

e4dccc2

Remove gitserver from tree

a1aa53a

smarterclayton force-pushed the cleanup_leftovers branch from d5c1cb3 to a1aa53a Compare September 14, 2018 16:45

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2018

smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2018

smarterclayton merged commit 5257c15 into openshift:master Sep 14, 2018

Conversation

smarterclayton commented Sep 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparees commented Sep 14, 2018

Uh oh!

smarterclayton commented Sep 14, 2018 via email

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh Sep 14, 2018

Choose a reason for hiding this comment

Uh oh!

smarterclayton Sep 14, 2018

Choose a reason for hiding this comment

Uh oh!

soltysh Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 14, 2018

Uh oh!

openshift-bot commented Sep 14, 2018

Uh oh!

openshift-bot commented Sep 14, 2018

Uh oh!

openshift-bot commented Sep 14, 2018

Uh oh!

openshift-ci-robot commented Sep 14, 2018

Uh oh!

openshift-ci-robot commented Sep 14, 2018

Uh oh!

smarterclayton commented Sep 14, 2018

Uh oh!

smarterclayton commented Sep 14, 2018

Uh oh!

smarterclayton commented Sep 14, 2018

Uh oh!

openshift-ci-robot commented Sep 14, 2018

Uh oh!

smarterclayton commented Sep 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

smarterclayton commented Sep 14, 2018 •

edited

Loading