-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Release payload creation should catch trivial YAML/JSON errors #21187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@abhinavdahiya @wking this will block new CVO payloads from being created that don't have valid manifest files |
|
/lgtm |
|
/retest |
d1b689e to
114c597
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging to minimize regressions across teams this week. Cluster up is being investigated by master team. |
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Would have prevented merge of the JSON/YAML error that broke
openshift/installer#422 (comment)