Skip to content

Revert "Temporarily flag the pruning test as flaky" #21573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 30, 2018
Merged

Revert "Temporarily flag the pruning test as flaky" #21573

openshift-merge-robot merged 1 commit into from
Nov 30, 2018

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Nov 29, 2018

This reverts commit c6b7b7e.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2018
@bparees
Copy link
Contributor Author

bparees commented Nov 29, 2018

@gabemontero @coreydaley fyi.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@bparees
Copy link
Contributor Author

bparees commented Nov 29, 2018

test in question passed:
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/21573/pull-ci-openshift-origin-master-e2e-gcp-builds/183

/test e2e-gcp-builds

@bparees
Copy link
Contributor Author

bparees commented Nov 30, 2018

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/21573/pull-ci-openshift-origin-master-e2e-gcp-builds/186

2/2.

merging.

@bparees bparees added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 30, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5fa8ee7 into openshift:master Nov 30, 2018
@bparees bparees deleted the pruningtest branch December 1, 2018 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@squeed squeed Awaiting requested review from squeed

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bparees @openshift-ci-robot @openshift-bot @openshift-merge-robot