cmd/openshift-tests/e2e: Skip "HostPath should support existing..." #21724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Contributor
|
how did #21713 merge if it added tests that don't pass? |
Contributor
|
oh these are the flaky ones? /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
These are the flaky ones. I'll force merge this if we flake on other tests. |
Member
|
Also proper fix for the hostpath tests - #21727 |
Contributor
|
#21727 allegedly fixes this, want to give that a chance to run: /hold |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
|
/retest |
These were recently added to the default suite in e068870 (Widen the smoke-4 suite to be the full parallel, minus known failures, 2019-01-01, openshift#21713), but they're blocking CI [1]. Skip them until we get the tests fixed. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1663327
wking
force-pushed
the
skip-HostPath-should-support-existing
branch
from
0d775b2 to
0af8dee
Compare
|
New changes are detected. LGTM label has been removed. |
Member
Author
Contributor
|
I merged #21727 which fixed this. Not necessary now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were recently added to the default suite in e068870 (#21713), but they're blocking CI. Skip them until we get the tests fixed.
CC @gnufied, @bparees