Skip to content

Add smoke test for machine-api#22015

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
derekwaynecarr:gate-machines-aws
Feb 15, 2019
Merged

Add smoke test for machine-api#22015
openshift-merge-robot merged 1 commit into
openshift:masterfrom
derekwaynecarr:gate-machines-aws

Conversation

@derekwaynecarr
Copy link
Copy Markdown
Member

Adds a basic smoke test that verifies every node is referenced by a machine.

Further iterations should scope this for IPI mode on AWS only.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2019
@derekwaynecarr
Copy link
Copy Markdown
Member Author

part of the effort to ensure we have basic smoke testing in e2e-aws for major feature areas.

/cc @enxebre @smarterclayton

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
o.Expect(err).NotTo(o.HaveOccurred())

g.By("checking for the openshift machine api operator")
// TODO: skip if platform != aws
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In follow ups we should probably try to make explicit the scenarios where we want the test to run so skipUnlessMachineAPIOperator doesn't skip silently for scenarios where the operator is expected to exist.

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 12, 2019

thanks a lot!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@derekwaynecarr
Copy link
Copy Markdown
Member Author

fixed up go vet

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 13, 2019

/test e2e-aws

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 13, 2019

The tests are not using latest version of installer g4bd58eb3d5a82058175d86f23ac6401aa70393a6 which includes openshift/installer#1241
They are using previews version https://storage.googleapis.com/origin-ci-test/pr-logs/pull/22015/pull-ci-openshift-origin-master-e2e-aws/3878/artifacts/e2e-aws/installer/version
Hence the tests won't pass. It might be ci-operator namespace caching, @bbguimaraes @petr-muller is there another solution than open a new dup PR?

@petr-muller
Copy link
Copy Markdown
Member

/retest

I have manually nuked the namespace, new test run should create a new one.

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link
Copy Markdown
Member Author

/test e2e-aws-serial

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 14, 2019

/test e2e-aws

1 similar comment
@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 14, 2019

/test e2e-aws

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Copy Markdown
Member

/retest

@ingvagabund
Copy link
Copy Markdown
Member

/test e2e-aws-serial

@ingvagabund
Copy link
Copy Markdown
Member

/test e2e-aws

1 similar comment
@ingvagabund
Copy link
Copy Markdown
Member

/test e2e-aws

@ingvagabund
Copy link
Copy Markdown
Member

/retest

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 14, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit e674c20 into openshift:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants