e2e: Test that all operators are stable#22058
Merged
smarterclayton merged 1 commit intoopenshift:masterfrom Feb 16, 2019
Merged
e2e: Test that all operators are stable#22058smarterclayton merged 1 commit intoopenshift:masterfrom
smarterclayton merged 1 commit intoopenshift:masterfrom
Conversation
This should catch flakes or failure retries
openshift-ci-robot
added
size/L
Contributor
|
/lgtm but w/o studying the old code..why wasn't the existing test accomplishing this goal? Because it was only checking available? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
smarterclayton
added
lgtm
Contributor
Author
|
yes. David was available but progressing. |
Contributor
Author
|
/retest |
wking
added a commit
to wking/origin
that referenced
this pull request
May 15, 2020
…terOperator We've been failing this test on Progressing=True since 6300a87 (e2e: Test that all operators are stable, 2019-02-15, openshift#22058). But the installer only cares about ClusterVersion Available=True [1], which means some operators who have leveled (as far as the cluster-version operator is concerned) may still have Progressing=True when the installer declares success. We aren't too concerned about that as long as operators are available and not degraded, so stop worrying about it in this test. This avoids failures like [2]: [sig-arch][Early] Managed cluster should start all core operators [Suite:openshift/conformance/parallel] fail [github.com/openshift/origin/test/extended/operators/operators.go:159]: May 8 13:27:58.992: Some cluster operators never became ready: kube-apiserver (Progressing=True NodeInstaller: NodeInstallerProgressing: 1 nodes are at revision 5; 2 nodes are at revision 7) although such failures rarely killed the job, because the cluster was happy enough by the time the "start all core operators" test was rerun to detect "flakes" at the end of the suite. [1]: https://github.com/openshift/installer/blob/aecb9201459e3e92f12344e78aaaf03b6550fde7/cmd/openshift-install/create.go#L382-L384 [2]: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/logs/release-openshift-ocp-installer-e2e-gcp-4.5/1040
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should catch flakes or failure retries