pkg/oc/cli/admin/release/new: Always include kube-etcd-signer-server#22325
pkg/oc/cli/admin/release/new: Always include kube-etcd-signer-server#22325wking wants to merge 1 commit intoopenshift:masterfrom
Conversation
Taking advantage of openshift/release@e43e260f59 (ci-operator: add kubecsr, 2019-03-06, openshift/release#3021) to get this installer dependency into the release image.
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
this can be declared as requirement in cluster-bootstrap and doesn't need to be hardcoded here. |
| @@ -46,7 +46,7 @@ func NewNewOptions(streams genericclioptions.IOStreams) *NewOptions { | |||
| // TODO: only cluster-version-operator and maybe CLI should be in this list, | |||
| // the others should always be referenced by the cluster-bootstrap or | |||
| // another operator. | |||
There was a problem hiding this comment.
the signer server lives in the bootstrap node and dies with it I believe. How does this work it just makes sure the image is always available? The TODO seems to say other stuff shouldn't be here just trying to understand workflow.
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing in favor of openshift/cluster-bootstrap#20. |
4 participants
Taking advantage of openshift/release@e43e260f59 (openshift/release#3021) to get this installer dependency into the release image.
Part of https://bugzilla.redhat.com/show_bug.cgi?id=1684670
CC @hexfusion